mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anirudh Rayabharam <mail@anirudhrb.com>
To: Matt Porter <mporter@kernel.crashing.org>,
	Alexandre Bounine <alex.bou9@gmail.com>
Cc: gregkh@linuxfoundation.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Anirudh Rayabharam <mail@anirudhrb.com>,
	linux-kernel@vger.kernel.org
Subject: [PATCH v2] rapidio: fix unused variable warning in rio_cm.c
Date: Thu,  6 May 2021 23:48:36 +0530	[thread overview]
Message-ID: <20210506181837.4758-1-mail@anirudhrb.com> (raw)

GCC produces an unused variable warning for 'rc':

	drivers/rapidio/rio_cm.c: In function ‘rio_txcq_handler’:
	drivers/rapidio/rio_cm.c:673:7: warning: variable ‘rc’ set but
	not used [-Wunused-but-set-variable]

The return value of rio_add_outb_message() is assigned to 'rc' but it
is never used. Fix this warning by logging an error if 'rc' is non-zero.

Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
---

Changes in v2:
Log an error instead of just removing 'rc'.

v1: https://lore.kernel.org/lkml/20210501055018.9244-1-mail@anirudhrb.com/

---
 drivers/rapidio/rio_cm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/rapidio/rio_cm.c b/drivers/rapidio/rio_cm.c
index 50ec53d67a4c..971a36f1a23a 100644
--- a/drivers/rapidio/rio_cm.c
+++ b/drivers/rapidio/rio_cm.c
@@ -677,6 +677,11 @@ static void rio_txcq_handler(struct cm_dev *cm, int slot)
 			cm->tx_buf[cm->tx_slot] = req->buffer;
 			rc = rio_add_outb_message(cm->mport, req->rdev, cmbox,
 						  req->buffer, req->len);
+			if (rc) {
+				riocm_error("Failed to add msg to tx queue (err=%d)",
+						rc);
+			}
+
 			kfree(req->buffer);
 			kfree(req);
 
-- 
2.26.2


             reply	other threads:[~2021-05-06 18:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 18:18 Anirudh Rayabharam [this message]
2021-05-07  6:39 ` Greg KH
2021-05-07 12:05   ` Anirudh Rayabharam
2021-05-07 12:16     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210506181837.4758-1-mail@anirudhrb.com \
    --to=mail@anirudhrb.com \
    --cc=alex.bou9@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mporter@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®