From: Vincent Donnefort <vincent.donnefort@arm.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Xuewen Yan <xuewen.yan94@gmail.com>,
mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, rostedt@goodmis.org,
bsegall@google.com, mgorman@suse.de, bristot@redhat.com,
linux-kernel@vger.kernel.org, zhang.lyra@gmail.com,
xuewyan@foxmail.com
Subject: Re: [PATCH v2] sched/pelt: Keep UTIL_AVG_UNCHANGED flag in sync when calculating last_enqueued_diff
Date: Fri, 7 May 2021 18:14:38 +0100 [thread overview]
Message-ID: <20210507171438.GA326455@e120877-lin.cambridge.arm.com> (raw)
In-Reply-To: <c265d9ab-f06f-692f-df43-464bf4f2ea68@arm.com>
[...]
> >
> > But we take the abs() of last_enqueued_diff.
> >
> > If we consider the following examples:
> >
> > enqueued_old = 5, enqueued_new = 9
> > diff = 5 - (9 + 1) => 5 - 10 => -5
> >
> > enqueued_old = 9, enqueued_new = 5
> > diff = 9 - (5 + 1) => 9 - 6 => 3
> >
> > In both cases the delta is supposed to be 4. But in the first case we end-up
> > with 5. In the second, we end-up with 3. That's why I meant the effect on the
> > diff depends on who's greater, ue.enqueued or task_util().
>
> Ah, OK, due to the abs() in within_margin(). But util's LSB is lost due
> to the flag anyway. Hence I assume e.g. enqueued_new = 9 should be
> (task_util() = 8) + 1 (| flag) in the example.
Yeah, I should have used an even number for the demonstration :-)
>
> OTHA, implementing UTIL_AVG_UNCHANGED as LSB and making this visible on
> the util_est 'API' has other issues too. The condition
> `!task_util_est(p)` can never be true in find_energy_efficient_cpu()
> because of UTIL_AVG_UNCHANGED.
>
> So why not use `UTIL_AVG_UNCHANGED = 0x80000000` and just keep its use
> internal (between cfs_se_util_change() and util_est_update()), i.e. not
> exporting it (via _task_util_est()) and not eclipsing util_est's LSB
> value?
As this would be fixing two issues at once, it's probably preferable.
[...]
> kernel/sched/fair.c | 5 +++--
> kernel/sched/pelt.h | 11 ++++++-----
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 1d75af1ecfb4..dd30e362c3cc 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -3902,7 +3902,7 @@ static inline unsigned long _task_util_est(struct task_struct *p)
> {
> struct util_est ue = READ_ONCE(p->se.avg.util_est);
>
> - return (max(ue.ewma, ue.enqueued) | UTIL_AVG_UNCHANGED);
> + return max(ue.ewma, (ue.enqueued & ~UTIL_AVG_UNCHANGED));
> }
>
> static inline unsigned long task_util_est(struct task_struct *p)
> @@ -4002,7 +4002,7 @@ static inline void util_est_update(struct cfs_rq *cfs_rq,
> * Reset EWMA on utilization increases, the moving average is used only
> * to smooth utilization decreases.
> */
Needs to be updated to add:
last_enqueued_diff = ue.enqueued & ~UTIL_AVG_UNCHANGED;
> - ue.enqueued = (task_util(p) | UTIL_AVG_UNCHANGED);
> + ue.enqueued = task_util(p);
> if (sched_feat(UTIL_EST_FASTUP)) {
> if (ue.ewma < ue.enqueued) {
> ue.ewma = ue.enqueued;
> @@ -4051,6 +4051,7 @@ static inline void util_est_update(struct cfs_rq *cfs_rq,
> ue.ewma += last_ewma_diff;
> ue.ewma >>= UTIL_EST_WEIGHT_SHIFT;
> done:
> + ue.enqueued |= UTIL_AVG_UNCHANGED;
> WRITE_ONCE(p->se.avg.util_est, ue);
>
> trace_sched_util_est_se_tp(&p->se);
> diff --git a/kernel/sched/pelt.h b/kernel/sched/pelt.h
> index 1462846d244e..476faf61f14a 100644
next prev parent reply other threads:[~2021-05-07 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 11:20 Xuewen Yan
2021-05-07 12:35 ` Vincent Donnefort
2021-05-07 13:36 ` Dietmar Eggemann
2021-05-07 15:38 ` Vincent Donnefort
2021-05-07 16:39 ` Dietmar Eggemann
2021-05-07 17:14 ` Vincent Donnefort [this message]
2021-05-08 1:23 ` Xuewen Yan
2021-05-10 9:27 ` Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507171438.GA326455@e120877-lin.cambridge.arm.com \
--to=vincent.donnefort@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=xuewen.yan94@gmail.com \
--cc=xuewyan@foxmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®