From: Vincent Donnefort <vincent.donnefort@arm.com>
To: Xuewen Yan <xuewen.yan94@gmail.com>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
Benjamin Segall <bsegall@google.com>,
Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Ryan Y <xuewyan@foxmail.com>
Subject: Re: [PATCH v2] sched/pelt: Keep UTIL_AVG_UNCHANGED flag in sync when calculating last_enqueued_diff
Date: Mon, 10 May 2021 10:27:51 +0100 [thread overview]
Message-ID: <20210510092751.GA36522@e120877-lin.cambridge.arm.com> (raw)
In-Reply-To: <CAB8ipk_VF0iD-4Lp73UsPYwz9wOawro5ZfyZihFU4Pu3_ehZjA@mail.gmail.com>
> > >
> > > static inline unsigned long task_util_est(struct task_struct *p)
> > > @@ -4002,7 +4002,7 @@ static inline void util_est_update(struct cfs_rq *cfs_rq,
> > > * Reset EWMA on utilization increases, the moving average is used only
> > > * to smooth utilization decreases.
> > > */
> >
> > Needs to be updated to add:
> >
> > last_enqueued_diff = ue.enqueued & ~UTIL_AVG_UNCHANGED;
>
> The flag had been cleared before, otherwise would return earlier, so
> there is no need to clear this flag again.
Indeed, my bad. All good then.
--
Vincent
prev parent reply other threads:[~2021-05-10 9:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 11:20 Xuewen Yan
2021-05-07 12:35 ` Vincent Donnefort
2021-05-07 13:36 ` Dietmar Eggemann
2021-05-07 15:38 ` Vincent Donnefort
2021-05-07 16:39 ` Dietmar Eggemann
2021-05-07 17:14 ` Vincent Donnefort
2021-05-08 1:23 ` Xuewen Yan
2021-05-10 9:27 ` Vincent Donnefort [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510092751.GA36522@e120877-lin.cambridge.arm.com \
--to=vincent.donnefort@arm.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=xuewen.yan94@gmail.com \
--cc=xuewyan@foxmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®