[PATCH v1 1/1] platform/x86: intel_punit_ipc: Append MODULE_DEVICE_TABLE for ACPI

[PATCH v1 1/1] platform/x86: intel_punit_ipc: Append MODULE_DEVICE_TABLE for ACPI

[Andy Shevchenko]

The intel_punit_ipc driver might be compiled as a module.
When udev handles the event of the devices appearing
the intel_punit_ipc module is missing.

Append MODULE_DEVICE_TABLE for ACPI case to fix the loading issue.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/platform/x86/intel_punit_ipc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c
index e0f838f0791b..b5763ca699b9 100644
--- a/drivers/platform/x86/intel_punit_ipc.c
+++ b/drivers/platform/x86/intel_punit_ipc.c
@@ -320,6 +320,7 @@ static const struct acpi_device_id punit_ipc_acpi_ids[] = {
 	{ "INT34D4", 0 },
 	{ }
 };
+MODULE_DEVICE_TABLE(acpi, punit_ipc_acpi_ids);
 
 static struct platform_driver intel_punit_ipc_driver = {
 	.probe = intel_punit_ipc_probe,
-- 
2.30.2

Re: [PATCH v1 1/1] platform/x86: intel_punit_ipc: Append MODULE_DEVICE_TABLE for ACPI

[Hans de Goede]

Hi,

On 5/19/21 12:15 PM, Andy Shevchenko wrote:
> The intel_punit_ipc driver might be compiled as a module.
> When udev handles the event of the devices appearing
> the intel_punit_ipc module is missing.
> 
> Append MODULE_DEVICE_TABLE for ACPI case to fix the loading issue.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

I will also include this in the next pdx86-fixes pull-req for 5.13.

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/intel_punit_ipc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/x86/intel_punit_ipc.c b/drivers/platform/x86/intel_punit_ipc.c
> index e0f838f0791b..b5763ca699b9 100644
> --- a/drivers/platform/x86/intel_punit_ipc.c
> +++ b/drivers/platform/x86/intel_punit_ipc.c
> @@ -320,6 +320,7 @@ static const struct acpi_device_id punit_ipc_acpi_ids[] = {
>  	{ "INT34D4", 0 },
>  	{ }
>  };
> +MODULE_DEVICE_TABLE(acpi, punit_ipc_acpi_ids);
>  
>  static struct platform_driver intel_punit_ipc_driver = {
>  	.probe = intel_punit_ipc_probe,
>