* [PATCH] firmware_loader: remove unneeded 'comma' macro
@ 2021-05-28 17:34 Masahiro Yamada
2021-06-11 0:02 ` Luis Chamberlain
2021-07-15 22:17 ` Luis Chamberlain
0 siblings, 2 replies; 3+ messages in thread
From: Masahiro Yamada @ 2021-05-28 17:34 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Masahiro Yamada, Luis Chamberlain, Rafael J. Wysocki, linux-kernel
Commit 553671b76859 ("firmware_loader: Fix labels with comma for builtin
firmware") added this line, which was unneeded.
The macro 'comma' is defined in scripts/Kbuild.include.
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---
drivers/base/firmware_loader/builtin/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/base/firmware_loader/builtin/Makefile b/drivers/base/firmware_loader/builtin/Makefile
index 5fa7ce3745a0..101754ad48d9 100644
--- a/drivers/base/firmware_loader/builtin/Makefile
+++ b/drivers/base/firmware_loader/builtin/Makefile
@@ -8,7 +8,6 @@ fwdir := $(addprefix $(srctree)/,$(filter-out /%,$(fwdir)))$(filter /%,$(fwdir))
obj-y := $(addsuffix .gen.o, $(subst $(quote),,$(CONFIG_EXTRA_FIRMWARE)))
FWNAME = $(patsubst $(obj)/%.gen.S,%,$@)
-comma := ,
FWSTR = $(subst $(comma),_,$(subst /,_,$(subst .,_,$(subst -,_,$(FWNAME)))))
ASM_WORD = $(if $(CONFIG_64BIT),.quad,.long)
ASM_ALIGN = $(if $(CONFIG_64BIT),3,2)
--
2.27.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] firmware_loader: remove unneeded 'comma' macro
2021-05-28 17:34 [PATCH] firmware_loader: remove unneeded 'comma' macro Masahiro Yamada
@ 2021-06-11 0:02 ` Luis Chamberlain
2021-07-15 22:17 ` Luis Chamberlain
1 sibling, 0 replies; 3+ messages in thread
From: Luis Chamberlain @ 2021-06-11 0:02 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Greg Kroah-Hartman, Rafael J. Wysocki, linux-kernel
On Sat, May 29, 2021 at 02:34:03AM +0900, Masahiro Yamada wrote:
> Commit 553671b76859 ("firmware_loader: Fix labels with comma for builtin
> firmware") added this line, which was unneeded.
>
> The macro 'comma' is defined in scripts/Kbuild.include.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] firmware_loader: remove unneeded 'comma' macro
2021-05-28 17:34 [PATCH] firmware_loader: remove unneeded 'comma' macro Masahiro Yamada
2021-06-11 0:02 ` Luis Chamberlain
@ 2021-07-15 22:17 ` Luis Chamberlain
1 sibling, 0 replies; 3+ messages in thread
From: Luis Chamberlain @ 2021-07-15 22:17 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: Greg Kroah-Hartman, Rafael J. Wysocki, linux-kernel
On Sat, May 29, 2021 at 02:34:03AM +0900, Masahiro Yamada wrote:
> Commit 553671b76859 ("firmware_loader: Fix labels with comma for builtin
> firmware") added this line, which was unneeded.
>
> The macro 'comma' is defined in scripts/Kbuild.include.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-15 22:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-28 17:34 [PATCH] firmware_loader: remove unneeded 'comma' macro Masahiro Yamada
2021-06-11 0:02 ` Luis Chamberlain
2021-07-15 22:17 ` Luis Chamberlain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®