* [PATCH] drm/mediatek: remove redundant error log print
@ 2021-06-03 11:14 Bernard Zhao
2021-06-08 0:18 ` Chun-Kuang Hu
0 siblings, 1 reply; 2+ messages in thread
From: Bernard Zhao @ 2021-06-03 11:14 UTC (permalink / raw)
To: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, dri-devel, linux-mediatek, linux-arm-kernel,
linux-kernel
Cc: Bernard Zhao
Fix coccicheck warning:
drivers/gpu/drm/mediatek/mtk_dsi.c:1074:2-9: line 1074 is
redundant because platform_get_irq() already prints an error.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
index ae403c67cbd9..e2e4fc8b1360 100644
--- a/drivers/gpu/drm/mediatek/mtk_dsi.c
+++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
@@ -1082,10 +1082,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
- if (ret) {
- dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
+ if (ret)
goto err_unregister_host;
- }
init_waitqueue_head(&dsi->irq_wait_queue);
--
2.31.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] drm/mediatek: remove redundant error log print
2021-06-03 11:14 [PATCH] drm/mediatek: remove redundant error log print Bernard Zhao
@ 2021-06-08 0:18 ` Chun-Kuang Hu
0 siblings, 0 replies; 2+ messages in thread
From: Chun-Kuang Hu @ 2021-06-08 0:18 UTC (permalink / raw)
To: Bernard Zhao
Cc: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, DRI Development,
moderated list:ARM/Mediatek SoC support, Linux ARM, linux-kernel
Hi, Bernard:
Bernard Zhao <bernard@vivo.com> 於 2021年6月3日 週四 下午7:15寫道：
>
> Fix coccicheck warning:
> drivers/gpu/drm/mediatek/mtk_dsi.c:1074:2-9: line 1074 is
> redundant because platform_get_irq() already prints an error.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
> drivers/gpu/drm/mediatek/mtk_dsi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c
> index ae403c67cbd9..e2e4fc8b1360 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dsi.c
> +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c
> @@ -1082,10 +1082,8 @@ static int mtk_dsi_probe(struct platform_device *pdev)
>
> ret = devm_request_irq(&pdev->dev, irq_num, mtk_dsi_irq,
> IRQF_TRIGGER_NONE, dev_name(&pdev->dev), dsi);
devm_request_irq() would have below call stack to allocate memory.
When allocate memory fail, it would not print any error message,
doesn't it?
devm_request_irq() -> devm_request_threaded_irq() -> devres_alloc() ->
devres_alloc_node() -> alloc_dr() -> kmalloc_node_track_caller()
Regards,
Chun-Kuang.
> - if (ret) {
> - dev_err(&pdev->dev, "failed to request mediatek dsi irq\n");
> + if (ret)
> goto err_unregister_host;
> - }
>
> init_waitqueue_head(&dsi->irq_wait_queue);
>
> --
> 2.31.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-08 0:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-03 11:14 [PATCH] drm/mediatek: remove redundant error log print Bernard Zhao
2021-06-08 0:18 ` Chun-Kuang Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®