* [PATCH 0/1] drm/amd/display: Add missing cases
@ 2021-06-04 13:16 Werner Sembach
2021-06-04 13:16 ` [PATCH 1/1] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc Werner Sembach
0 siblings, 1 reply; 3+ messages in thread
From: Werner Sembach @ 2021-06-04 13:16 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
airlied, daniel, amd-gfx, dri-devel, linux-kernel
Rev 2: Fix small typo in commit message.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc
2021-06-04 13:16 [PATCH 0/1] drm/amd/display: Add missing cases Werner Sembach
@ 2021-06-04 13:16 ` Werner Sembach
2021-06-04 13:32 ` Harry Wentland
0 siblings, 1 reply; 3+ messages in thread
From: Werner Sembach @ 2021-06-04 13:16 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, alexander.deucher, christian.koenig,
airlied, daniel, amd-gfx, dri-devel, linux-kernel
Cc: Werner Sembach
convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an
integer had the cases for COLOR_DEPTH_999 and COLOR_DEPTH_111111 missing.
Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index 389eff96fcf6..6e82889271d5 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -6515,6 +6515,10 @@ static int convert_dc_color_depth_into_bpc (enum dc_color_depth display_color_de
return 14;
case COLOR_DEPTH_161616:
return 16;
+ case COLOR_DEPTH_999:
+ return 9;
+ case COLOR_DEPTH_111111:
+ return 11;
default:
break;
}
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc
2021-06-04 13:16 ` [PATCH 1/1] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc Werner Sembach
@ 2021-06-04 13:32 ` Harry Wentland
0 siblings, 0 replies; 3+ messages in thread
From: Harry Wentland @ 2021-06-04 13:32 UTC (permalink / raw)
To: Werner Sembach, sunpeng.li, alexander.deucher, christian.koenig,
airlied, daniel, amd-gfx, dri-devel, linux-kernel
On 2021-06-04 9:16 a.m., Werner Sembach wrote:
> convert_dc_color_depth_into_bpc() that converts the enum dc_color_depth to an
> integer had the cases for COLOR_DEPTH_999 and COLOR_DEPTH_111111 missing.
>
> Signed-off-by: Werner Sembach <wse@tuxedocomputers.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 389eff96fcf6..6e82889271d5 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6515,6 +6515,10 @@ static int convert_dc_color_depth_into_bpc (enum dc_color_depth display_color_de
> return 14;
> case COLOR_DEPTH_161616:
> return 16;
> + case COLOR_DEPTH_999:
> + return 9;
> + case COLOR_DEPTH_111111:
> + return 11;
The color_depth returned by convert_color_depth_from_display_info will never return
9 or 11 bpc color depth. If we add these we should add them in all places where
they're needed and test the whole sequence.
I'm a bit surprised to find DC has support for 9 bpc and 11 bpc color depth but am
not sure how well tested that is.
Harry
> default:
> break;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-04 13:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-04 13:16 [PATCH 0/1] drm/amd/display: Add missing cases Werner Sembach
2021-06-04 13:16 ` [PATCH 1/1] drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc Werner Sembach
2021-06-04 13:32 ` Harry Wentland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®