* [PATCH] platform/x86: dell-wmi-sysman: set fw_attr_class storage-class to static
@ 2021-06-09 15:34 trix
2021-06-09 16:04 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: trix @ 2021-06-09 15:34 UTC (permalink / raw)
To: divya.bharathi, prasanth.ksr, hdegoede, mgross
Cc: Dell.Client.Kernel, platform-driver-x86, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
An allyesconfig has this linking error
drivers/platform/x86/think-lmi.o:
multiple definition of `fw_attr_class'
drivers/platform/x86/dell/dell-wmi-sysman/sysman.o:
first defined here
fw_attr_class is only used locally, so change to static
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
index 1378c18786582..636bdfa83284d 100644
--- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
+++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
@@ -25,7 +25,7 @@ struct wmi_sysman_priv wmi_priv = {
/* reset bios to defaults */
static const char * const reset_types[] = {"builtinsafe", "lastknowngood", "factory", "custom"};
static int reset_option = -1;
-struct class *fw_attr_class;
+static struct class *fw_attr_class;
/**
--
2.26.3
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] platform/x86: dell-wmi-sysman: set fw_attr_class storage-class to static
2021-06-09 15:34 [PATCH] platform/x86: dell-wmi-sysman: set fw_attr_class storage-class to static trix
@ 2021-06-09 16:04 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-06-09 16:04 UTC (permalink / raw)
To: trix, divya.bharathi, prasanth.ksr, mgross
Cc: Dell.Client.Kernel, platform-driver-x86, linux-kernel
Hi Tom,
On 6/9/21 5:34 PM, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> An allyesconfig has this linking error
> drivers/platform/x86/think-lmi.o:
> multiple definition of `fw_attr_class'
> drivers/platform/x86/dell/dell-wmi-sysman/sysman.o:
> first defined here
>
> fw_attr_class is only used locally, so change to static
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Thank you for your 2 patches, I just merged another patch doing
the same earlier today.
Regards,
Hans
> ---
> drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> index 1378c18786582..636bdfa83284d 100644
> --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c
> @@ -25,7 +25,7 @@ struct wmi_sysman_priv wmi_priv = {
> /* reset bios to defaults */
> static const char * const reset_types[] = {"builtinsafe", "lastknowngood", "factory", "custom"};
> static int reset_option = -1;
> -struct class *fw_attr_class;
> +static struct class *fw_attr_class;
>
>
> /**
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-09 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 15:34 [PATCH] platform/x86: dell-wmi-sysman: set fw_attr_class storage-class to static trix
2021-06-09 16:04 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®