* [PATCH] platform/x86: thinkpad-lmi: set fw_attr_class storage-class to static
@ 2021-06-09 15:35 trix
0 siblings, 0 replies; only message in thread
From: trix @ 2021-06-09 15:35 UTC (permalink / raw)
To: markpearson, hdegoede, mgross; +Cc: platform-driver-x86, linux-kernel, Tom Rix
From: Tom Rix <trix@redhat.com>
An allyesconfig has this linking error
drivers/platform/x86/think-lmi.o:
multiple definition of `fw_attr_class'
drivers/platform/x86/dell/dell-wmi-sysman/sysman.o:
first defined here
fw_attr_class is only used locally, so change to static
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/platform/x86/think-lmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
index 782d8e3fe7a1e..c6413b906e4a3 100644
--- a/drivers/platform/x86/think-lmi.c
+++ b/drivers/platform/x86/think-lmi.c
@@ -134,7 +134,7 @@ static const char * const encoding_options[] = {
[TLMI_ENCODING_SCANCODE] = "scancode",
};
static struct think_lmi tlmi_priv;
-struct class *fw_attr_class;
+static struct class *fw_attr_class;
/* ------ Utility functions ------------*/
/* Convert BIOS WMI error string to suitable error code */
--
2.26.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-09 15:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 15:35 [PATCH] platform/x86: thinkpad-lmi: set fw_attr_class storage-class to static trix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®