mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] function mana_hwc_create_wq leaks memory
@ 2021-06-10 15:29 Dhiraj Shah
  2021-06-10 17:18 ` Dexuan Cui
  0 siblings, 1 reply; 5+ messages in thread
From: Dhiraj Shah @ 2021-06-10 15:29 UTC (permalink / raw)
  Cc: find.dhiraj, K. Y. Srinivasan, Haiyang Zhang, Stephen Hemminger,
	Wei Liu, Dexuan Cui, David S. Miller, Jakub Kicinski,
	Shachar Raindel, Colin Ian King, linux-hyperv, netdev,
	linux-kernel

memory space allocated for the queue in function
mana_gd_create_hwc_queue is not freed during error condition.

Signed-off-by: Dhiraj Shah <find.dhiraj@gmail.com>
---
 drivers/net/ethernet/microsoft/mana/hw_channel.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
index 1a923fd99990..4aa4bda518fb 100644
--- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
+++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
@@ -501,8 +501,10 @@ static int mana_hwc_create_wq(struct hw_channel_context *hwc,
 	*hwc_wq_ptr = hwc_wq;
 	return 0;
 out:
-	if (err)
+	if (err) {
+		kfree(queue);
 		mana_hwc_destroy_wq(hwc, hwc_wq);
+	}
 	return err;
 }
 
-- 
2.30.1 (Apple Git-130)


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-06-10 20:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 15:29 [PATCH] function mana_hwc_create_wq leaks memory Dhiraj Shah
2021-06-10 17:18 ` Dexuan Cui
2021-06-10 17:28   ` Dexuan Cui
2021-06-10 19:53     ` Dhiraj Shah
2021-06-10 20:03       ` Dexuan Cui

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®