* [PATCH v2 1/1] platform/chrome: cros_ec_typec: Put fwnode in error case during ->probe()
@ 2021-06-15 21:51 Andy Shevchenko
0 siblings, 0 replies; only message in thread
From: Andy Shevchenko @ 2021-06-15 21:51 UTC (permalink / raw)
To: Prashant Malani, linux-kernel
Cc: Benson Leung, Enric Balletbo i Serra, Guenter Roeck, Andy Shevchenko
device_for_each_child_node() bumps a reference counting of a returned variable.
We have to balance it whenever we return to the caller.
Fixes: fdc6b21e2444 ("platform/chrome: Add Type C connector class driver")
Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: Prashant Malani <pmalani@chromium.org>
---
v2: added comment (Prashant), added Rb tag (Prashant)
drivers/platform/chrome/cros_ec_typec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
index 27c068c4c38d..99fdc1156392 100644
--- a/drivers/platform/chrome/cros_ec_typec.c
+++ b/drivers/platform/chrome/cros_ec_typec.c
@@ -375,6 +375,8 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
return 0;
unregister_ports:
+ /* Drop the referece that bumped by device_for_each_child_node() */
+ fwnode_handle_put(fwnode);
cros_unregister_ports(typec);
return ret;
}
--
2.32.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-15 21:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 21:51 [PATCH v2 1/1] platform/chrome: cros_ec_typec: Put fwnode in error case during ->probe() Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®