From: Sudeep Holla <sudeep.holla@arm.com>
To: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Cc: james.morse@arm.com, gregkh@linuxfoundation.org,
rafael@kernel.org, linux-kernel@vger.kernel.org,
bobo.shaobowang@huawei.com, Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH v2] cacheinfo: clear cache_leaves(cpu) in free_cache_attributes()
Date: Wed, 14 Jul 2021 10:03:53 +0100 [thread overview]
Message-ID: <20210714090353.6ncnqof74hwbx2gf@bogus> (raw)
In-Reply-To: <1626226375-58730-1-git-send-email-wangxiongfeng2@huawei.com>
On Wed, Jul 14, 2021 at 09:32:55AM +0800, Xiongfeng Wang wrote:
> On ARM64, when PPTT(Processor Properties Topology Table) is not
> implemented in ACPI boot, we will goto 'free_ci' with the following
> print:
> Unable to detect cache hierarchy for CPU 0
>
> But some other codes may still use 'num_leaves' to iterate through the
> 'info_list', such as get_cpu_cacheinfo_id(). If 'info_list' is NULL , it
> would crash. So clear 'num_leaves' in free_cache_attributes().
>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
prev parent reply other threads:[~2021-07-14 9:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 1:32 Xiongfeng Wang
2021-07-14 9:03 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714090353.6ncnqof74hwbx2gf@bogus \
--to=sudeep.holla@arm.com \
--cc=bobo.shaobowang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.morse@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=wangxiongfeng2@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®