From: Daniel Jordan <daniel.m.jordan@oracle.com>
To: 20210712162655.w3j6uczwbfkzazvt@oracle.com
Cc: bsegall@google.com, dietmar.eggemann@arm.com,
juri.lelli@redhat.com, linux-kernel@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org, pjt@google.com,
vincent.guittot@linaro.org, zhangqiao22@huawei.com
Subject: Re: [PATCH -next] sched: Dec __cfs_bandwith_used in destroy_cfs_bandwidth()
Date: Wed, 14 Jul 2021 09:22:33 -0400 [thread overview]
Message-ID: <20210714132233.o4zvgdiiugxf6yxk@oracle.com> (raw)
In-Reply-To: <3b2eb2c6-20d5-9f13-09f9-77f87f333b8d@huawei.com>
On Wed, Jul 14, 2021 at 07:20:39PM +0800, Zhang Qiao wrote:
> And i have another thought is that we can hold the
> hotplug lock before calling cfs_bandwidth_usage_dec().
> This way, fewer modifications are involved.
> What do you think about it?
It is fewer lines, but then hotplug lock is taken pointlessly for
!JUMP_LABEL. Not a huge deal in a slow path like this, just a bit lame.
Adding a new variant seems cleaner if more verbose.
next prev parent reply other threads:[~2021-07-14 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 11:20 Zhang Qiao
2021-07-14 13:22 ` Daniel Jordan [this message]
2021-07-15 2:07 ` Zhang Qiao
-- strict thread matches above, loose matches on Subject: below --
2021-07-06 8:38 Zhang Qiao
2021-07-12 16:26 ` Daniel Jordan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714132233.o4zvgdiiugxf6yxk@oracle.com \
--to=daniel.m.jordan@oracle.com \
--cc=20210712162655.w3j6uczwbfkzazvt@oracle.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=vincent.guittot@linaro.org \
--cc=zhangqiao22@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®