From: Will Deacon <will@kernel.org>
To: Andrew Delgadillo <adelg@google.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
masahiroy@kernel.org
Subject: Re: [PATCH] arm64: clean vdso files
Date: Tue, 10 Aug 2021 14:52:36 +0100 [thread overview]
Message-ID: <20210810135236.GA3101@willie-the-truck> (raw)
In-Reply-To: <20210809191414.3572827-1-adelg@google.com>
[+Masahiro]
On Mon, Aug 09, 2021 at 07:14:14PM +0000, Andrew Delgadillo wrote:
> commit a5b8ca97fbf8 ("arm64: do not descend to vdso directories twice")
> changes the cleaning behavior of arm64's vdso files, in that vdso.lds,
> vdso.so, and vdso.so.dbg are not removed upon a 'make clean/mrproper':
>
> $ make defconfig ARCH=arm64
> $ make ARCH=arm64
> $ make mrproper ARCH=arm64
> $ git clean -nxdf
> Would remove arch/arm64/kernel/vdso/vdso.lds
> Would remove arch/arm64/kernel/vdso/vdso.so
> Would remove arch/arm64/kernel/vdso/vdso.so.dbg
>
> To remedy this, manually descend into arch/arm64/kernel/vdso upon
> cleaning.
>
> After this commit:
> $ make defconfig ARCH=arm64
> $ make ARCH=arm64
> $ make mrproper ARCH=arm64
> $ git clean -nxdf
> <empty>
Well spotted!
> Signed-off-by: Andrew Delgadillo <adelg@google.com>
> ---
> arch/arm64/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/Makefile b/arch/arm64/Makefile
> index b52481f0605d..ef6598cb5a9b 100644
> --- a/arch/arm64/Makefile
> +++ b/arch/arm64/Makefile
> @@ -181,6 +181,7 @@ archprepare:
> # We use MRPROPER_FILES and CLEAN_FILES now
> archclean:
> $(Q)$(MAKE) $(clean)=$(boot)
> + $(Q)$(MAKE) $(clean)=arch/arm64/kernel/vdso
I think we also need to clean the vdso32 directory here. Please can you
send a v2 with that added?
Cheers,
Will
next prev parent reply other threads:[~2021-08-10 13:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 19:14 Andrew Delgadillo
2021-08-10 5:57 ` Greg KH
2021-08-10 13:52 ` Will Deacon [this message]
2021-08-11 1:15 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210810135236.GA3101@willie-the-truck \
--to=will@kernel.org \
--cc=adelg@google.com \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®