From: Kalesh Singh <kaleshsingh@google.com>
To: unlisted-recipients:; (no To-header on input)
Cc: surenb@google.com, hridya@google.com, gregkh@linuxfoundation.org,
john.reitan@arm.com, orjan.eide@arm.com, mark.underwood@arm.com,
gary.sweet@broadcom.com, stephen.mansfield@imgtec.com,
kernel-team@android.com, Kalesh Singh <kaleshsingh@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [RESEND v2] tracing/gpu: Add imported size to gpu_mem_imported tracepoint
Date: Tue, 31 Aug 2021 17:02:29 +0000 [thread overview]
Message-ID: <20210831170233.1409537-1-kaleshsingh@google.com> (raw)
The existing gpu_mem_total tracepoint provides GPU drivers a uniform way
to report the per-process and system-wide GPU memory usage. This
tracepoint reports a single total of the GPU private allocations and the
imported memory. [1]
To allow distinguishing GPU private vs imported memory, add an
imported_size field to the gpu_mem_total tracepoint. GPU drivers can use
this new field to report the per-process and global GPU-imported memory
in a uniform way.
User space tools can detect and handle the old vs new gpu_mem_total
format via the gpu_mem/gpu_mem_total/format file.
[1] https://lore.kernel.org/r/20200302234840.57188-1-zzyiwei@google.com/
Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
---
include/trace/events/gpu_mem.h | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/include/trace/events/gpu_mem.h b/include/trace/events/gpu_mem.h
index 26d871f96e94..ae6fab6bab7b 100644
--- a/include/trace/events/gpu_mem.h
+++ b/include/trace/events/gpu_mem.h
@@ -15,7 +15,7 @@
/*
* The gpu_memory_total event indicates that there's an update to either the
- * global or process total gpu memory counters.
+ * global or process total and imported gpu memory counters.
*
* This event should be emitted whenever the kernel device driver allocates,
* frees, imports, unimports memory in the GPU addressable space.
@@ -24,31 +24,36 @@
*
* @pid: Put 0 for global total, while positive pid for process total.
*
- * @size: Size of the allocation in bytes.
+ * @size: Total size of allocated and imported memory in bytes.
+ *
+ * @imported_size: Total size of imported memory in bytes.
*
*/
TRACE_EVENT(gpu_mem_total,
- TP_PROTO(uint32_t gpu_id, uint32_t pid, uint64_t size),
+ TP_PROTO(uint32_t gpu_id, uint32_t pid, uint64_t size, uint64_t imported_size),
- TP_ARGS(gpu_id, pid, size),
+ TP_ARGS(gpu_id, pid, size, imported_size),
TP_STRUCT__entry(
__field(uint32_t, gpu_id)
__field(uint32_t, pid)
__field(uint64_t, size)
+ __field(uint64_t, imported_size)
),
TP_fast_assign(
__entry->gpu_id = gpu_id;
__entry->pid = pid;
__entry->size = size;
+ __entry->imported_size = imported_size;
),
- TP_printk("gpu_id=%u pid=%u size=%llu",
+ TP_printk("gpu_id=%u pid=%u size=%llu imported_size=%llu",
__entry->gpu_id,
__entry->pid,
- __entry->size)
+ __entry->size,
+ __entry->imported_size)
);
#endif /* _TRACE_GPU_MEM_H */
base-commit: 9c849ce86e0fa93a218614eac562ace44053d7ce
--
2.33.0.259.gc128427fd7-goog
next reply other threads:[~2021-08-31 17:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 17:02 Kalesh Singh [this message]
2021-09-02 16:29 ` Kalesh Singh
2021-09-03 20:30 ` Steven Rostedt
2021-09-03 22:36 ` Kalesh Singh
2021-09-07 17:49 ` Steven Rostedt
2021-09-07 17:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210831170233.1409537-1-kaleshsingh@google.com \
--to=kaleshsingh@google.com \
--cc=gary.sweet@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=john.reitan@arm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.underwood@arm.com \
--cc=mingo@redhat.com \
--cc=orjan.eide@arm.com \
--cc=rostedt@goodmis.org \
--cc=stephen.mansfield@imgtec.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®