From: Steven Rostedt <rostedt@goodmis.org>
To: Kalesh Singh <kaleshsingh@google.com>
Cc: surenb@google.com, hridya@google.com, gregkh@linuxfoundation.org,
john.reitan@arm.com, orjan.eide@arm.com, mark.underwood@arm.com,
gary.sweet@broadcom.com, stephen.mansfield@imgtec.com,
kernel-team@android.com, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND v2] tracing/gpu: Add imported size to gpu_mem_imported tracepoint
Date: Fri, 3 Sep 2021 16:30:47 -0400 [thread overview]
Message-ID: <20210903163047.20e4f286@gandalf.local.home> (raw)
In-Reply-To: <20210831170233.1409537-1-kaleshsingh@google.com>
On Tue, 31 Aug 2021 17:02:29 +0000
Kalesh Singh <kaleshsingh@google.com> wrote:
> The existing gpu_mem_total tracepoint provides GPU drivers a uniform way
> to report the per-process and system-wide GPU memory usage. This
> tracepoint reports a single total of the GPU private allocations and the
> imported memory. [1]
>
> To allow distinguishing GPU private vs imported memory, add an
> imported_size field to the gpu_mem_total tracepoint. GPU drivers can use
> this new field to report the per-process and global GPU-imported memory
> in a uniform way.
>
> User space tools can detect and handle the old vs new gpu_mem_total
> format via the gpu_mem/gpu_mem_total/format file.
>
> [1] https://lore.kernel.org/r/20200302234840.57188-1-zzyiwei@google.com/
>
> Signed-off-by: Kalesh Singh <kaleshsingh@google.com>
> ---
> include/trace/events/gpu_mem.h | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
This is that trace event that doesn't have any in tree callers, right? I
thought there was going to be some soon.
For the updates to the tracing side (besides not having any users), it
looks trivial to me.
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
But this needs to be pulled in by one of the GPU maintainers.
-- Steve
next prev parent reply other threads:[~2021-09-03 20:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 17:02 Kalesh Singh
2021-09-02 16:29 ` Kalesh Singh
2021-09-03 20:30 ` Steven Rostedt [this message]
2021-09-03 22:36 ` Kalesh Singh
2021-09-07 17:49 ` Steven Rostedt
2021-09-07 17:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210903163047.20e4f286@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=gary.sweet@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hridya@google.com \
--cc=john.reitan@arm.com \
--cc=kaleshsingh@google.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.underwood@arm.com \
--cc=mingo@redhat.com \
--cc=orjan.eide@arm.com \
--cc=stephen.mansfield@imgtec.com \
--cc=surenb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®