mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kari Argillander <kari.argillander@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	ntfs3@lists.linux.dev, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] fs/ntfs3: Remove redundant initialization of variable err
Date: Fri, 3 Sep 2021 17:46:01 +0300	[thread overview]
Message-ID: <20210903144601.jrqsjeaetxm3bcr3@kari-VirtualBox> (raw)
In-Reply-To: <20210903132458.14342-1-colin.king@canonical.com>

On Fri, Sep 03, 2021 at 02:24:58PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable err is being initialized with a value that is never read, it
> is being updated later on. The assignment is redundant and can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Kari Argillander <kari.argillander@gmail.com>

Please note Konstantin that you should not yet, put this to master. You
can collect these already, but if ntfs3 get merged to 5.15 we will start
start master again later. You could but these in example devel if you
want.

Then we also need branch just for bug fixes. Example this will have to
go to 5.16 because it is not bug fix. Our master is our for-next branch
so this will go there when time comes.

> ---
>  fs/ntfs3/index.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 0daca9adc54c..b1175542d854 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -1401,7 +1401,7 @@ int indx_find_raw(struct ntfs_index *indx, struct ntfs_inode *ni,
>  static int indx_create_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
>  				CLST *vbn)
>  {
> -	int err = -ENOMEM;
> +	int err;
>  	struct ntfs_sb_info *sbi = ni->mi.sbi;
>  	struct ATTRIB *bitmap;
>  	struct ATTRIB *alloc;
> -- 
> 2.32.0
> 

  reply	other threads:[~2021-09-03 14:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-03 13:24 Colin King
2021-09-03 14:46 ` Kari Argillander [this message]
2021-09-13 16:49 ` Konstantin Komarov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210903144601.jrqsjeaetxm3bcr3@kari-VirtualBox \
    --to=kari.argillander@gmail.com \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ntfs3@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®