From: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
To: Colin King <colin.king@canonical.com>, <ntfs3@lists.linux.dev>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][next] fs/ntfs3: Remove redundant initialization of variable err
Date: Mon, 13 Sep 2021 19:49:51 +0300 [thread overview]
Message-ID: <472ecb1c-578d-137a-9ec1-182642dac037@paragon-software.com> (raw)
In-Reply-To: <20210903132458.14342-1-colin.king@canonical.com>
On 03.09.2021 16:24, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable err is being initialized with a value that is never read, it
> is being updated later on. The assignment is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> fs/ntfs3/index.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ntfs3/index.c b/fs/ntfs3/index.c
> index 0daca9adc54c..b1175542d854 100644
> --- a/fs/ntfs3/index.c
> +++ b/fs/ntfs3/index.c
> @@ -1401,7 +1401,7 @@ int indx_find_raw(struct ntfs_index *indx, struct ntfs_inode *ni,
> static int indx_create_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
> CLST *vbn)
> {
> - int err = -ENOMEM;
> + int err;
> struct ntfs_sb_info *sbi = ni->mi.sbi;
> struct ATTRIB *bitmap;
> struct ATTRIB *alloc;
>
Hi Colin, thanks for the patch - applied it.
Best regards.
prev parent reply other threads:[~2021-09-13 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-03 13:24 Colin King
2021-09-03 14:46 ` Kari Argillander
2021-09-13 16:49 ` Konstantin Komarov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=472ecb1c-578d-137a-9ec1-182642dac037@paragon-software.com \
--to=almaz.alexandrovich@paragon-software.com \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®