From: "Michal Koutný" <mkoutny@suse.com>
To: brookxu <brookxu.cn@gmail.com>
Cc: Vipin Sharma <vipinsh@google.com>,
tj@kernel.org, lizefan.x@bytedance.com, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood
Date: Fri, 10 Sep 2021 11:23:10 +0200 [thread overview]
Message-ID: <20210910092310.GA18084@blackbody.suse.cz> (raw)
In-Reply-To: <478e986c-bc69-62b8-936e-5b075f9270b4@gmail.com>
On Fri, Sep 10, 2021 at 01:30:46PM +0800, brookxu <brookxu.cn@gmail.com> wrote:
> I am a bit confused here. For misc_cgroup, we can only be rejected when the count
> touch Limit, but there may be other more reasons for other subsystems.
Sorry, I wasn't clear about that -- the failures I meant to be counted
here were only the ones caused by (an ancestor) limit. Maybe there's a
better naem for that.
> Therefore, when we are rejected, does it mean that we have touch
> Limit? If so, do we still need to distinguish between max and fail?
> (for misc_cgroup)
r
`- c1
`- c2.max
`- c3
`- c4.max
`- task t
`- c5
Assuming c2.max < c4.max, when a task t calls try_charge and it fails
because of c2.max, then the 'max' event is counted to c2 (telling that
the limit is perhaps low) and the 'fail' event is counted to c4 (telling
you where the troubles originated). That is my idea. Although in the
case of short-lived cgroups, you'd likely only get the hierarchically
aggregated 'fail' events from c3 or higher with lower (spatial)
precision.
What would be the type of information useful for your troubleshooting?
Cheers,
Michal
next prev parent reply other threads:[~2021-09-10 9:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 5:24 [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local brookxu
2021-09-08 5:24 ` [RFC PATCH 2/3] misc_cgroup: introduce misc.failcnt for V1 brookxu
2021-09-09 14:37 ` Michal Koutný
2021-09-08 5:24 ` [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood brookxu
2021-09-09 14:37 ` Michal Koutný
2021-09-09 16:49 ` Vipin Sharma
2021-09-09 18:56 ` Michal Koutný
2021-09-10 5:30 ` brookxu
2021-09-10 9:23 ` Michal Koutný [this message]
2021-09-10 14:29 ` brookxu.cn
2021-09-10 15:36 ` Michal Koutný
2021-09-10 16:29 ` Tejun Heo
2021-09-10 17:16 ` Vipin Sharma
2021-09-10 17:19 ` Tejun Heo
2021-09-10 17:31 ` Vipin Sharma
2021-09-10 17:37 ` Tejun Heo
2021-09-09 14:37 ` [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local Michal Koutný
2021-09-09 17:08 ` Vipin Sharma
2021-09-10 5:20 ` brookxu
2021-09-10 10:33 ` Michal Koutný
2021-09-10 16:32 ` Tejun Heo
2021-09-09 16:56 ` Vipin Sharma
2021-09-10 5:21 ` brookxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910092310.GA18084@blackbody.suse.cz \
--to=mkoutny@suse.com \
--cc=brookxu.cn@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®