From: Tejun Heo <tj@kernel.org>
To: "Michal Koutný" <mkoutny@suse.com>
Cc: "brookxu.cn" <brookxu.cn@gmail.com>,
Vipin Sharma <vipinsh@google.com>,
lizefan.x@bytedance.com, hannes@cmpxchg.org,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood
Date: Fri, 10 Sep 2021 06:29:41 -1000 [thread overview]
Message-ID: <YTuH9fULTx+pLuuH@slm.duckdns.org> (raw)
In-Reply-To: <20210910153609.GC24156@blackbody.suse.cz>
Hello,
On Fri, Sep 10, 2021 at 05:36:09PM +0200, Michal Koutný wrote:
> If there's a limit on certain level with otherwise unconstrained cgroup
> structure below (a valid config too), the 'fail' counter would help
> determining what the affected cgroup is. Does that make sense to you?
While the desire to make the interface complete is understandable, I don't
think we need to go too far in that direction given that debugging these
configuration issues requires human intervention anyway and providing
overall information is often enough of aid especially for simple controllers
like misc/pid. So, let's stick to something consistent and simple even if
not complete and definitely not name them "fail" even if we add them.
Thanks.
--
tejun
next prev parent reply other threads:[~2021-09-10 16:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 5:24 [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local brookxu
2021-09-08 5:24 ` [RFC PATCH 2/3] misc_cgroup: introduce misc.failcnt for V1 brookxu
2021-09-09 14:37 ` Michal Koutný
2021-09-08 5:24 ` [RFC PATCH 3/3] misc_cgroup: remove error log to avoid log flood brookxu
2021-09-09 14:37 ` Michal Koutný
2021-09-09 16:49 ` Vipin Sharma
2021-09-09 18:56 ` Michal Koutný
2021-09-10 5:30 ` brookxu
2021-09-10 9:23 ` Michal Koutný
2021-09-10 14:29 ` brookxu.cn
2021-09-10 15:36 ` Michal Koutný
2021-09-10 16:29 ` Tejun Heo [this message]
2021-09-10 17:16 ` Vipin Sharma
2021-09-10 17:19 ` Tejun Heo
2021-09-10 17:31 ` Vipin Sharma
2021-09-10 17:37 ` Tejun Heo
2021-09-09 14:37 ` [RFC PATCH 1/3] misc_cgroup: introduce misc.events and misc_events.local Michal Koutný
2021-09-09 17:08 ` Vipin Sharma
2021-09-10 5:20 ` brookxu
2021-09-10 10:33 ` Michal Koutný
2021-09-10 16:32 ` Tejun Heo
2021-09-09 16:56 ` Vipin Sharma
2021-09-10 5:21 ` brookxu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTuH9fULTx+pLuuH@slm.duckdns.org \
--to=tj@kernel.org \
--cc=brookxu.cn@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=mkoutny@suse.com \
--cc=vipinsh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®