From: Sven Peter <sven@svenpeter.dev>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "Sven Peter" <sven@svenpeter.dev>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Guido Günther" <agx@sigxcpu.org>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Hector Martin" <marcan@marcan.st>,
"Mohamed Mediouni" <mohamed.mediouni@caramail.com>,
"Stan Skowronek" <stan@corellium.com>,
"Mark Kettenis" <mark.kettenis@xs4all.nl>,
"Alexander Graf" <graf@amazon.com>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>
Subject: [RFT PATCH 6/9] usb: typec: tipd: Setup IntMask explicitly
Date: Sat, 18 Sep 2021 14:09:31 +0200 [thread overview]
Message-ID: <20210918120934.28252-7-sven@svenpeter.dev> (raw)
In-Reply-To: <20210918120934.28252-1-sven@svenpeter.dev>
Right now the code relies on the bootloader to set up the interrupt mask
correctly. This usually works but let's make sure to do it explicitly to
guarantee it will always work.
Signed-off-by: Sven Peter <sven@svenpeter.dev>
---
drivers/usb/typec/tipd/core.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c
index d191e7435018..2058e8cca631 100644
--- a/drivers/usb/typec/tipd/core.c
+++ b/drivers/usb/typec/tipd/core.c
@@ -728,6 +728,24 @@ static int tps6598x_probe(struct i2c_client *client)
dev_err(&client->dev, "failed to register partner\n");
}
+ if (tps->hw->use_int1) {
+ ret = tps6598x_write64(tps, TPS_REG_INT_MASK1,
+ tps->hw->irq_power_status_update |
+ tps->hw->irq_data_status_update |
+ tps->hw->irq_plug_event);
+ if (ret)
+ goto err_role_put;
+ }
+
+ if (tps->hw->use_int2) {
+ ret = tps6598x_write64(tps, TPS_REG_INT_MASK2,
+ tps->hw->irq_power_status_update |
+ tps->hw->irq_data_status_update |
+ tps->hw->irq_plug_event);
+ if (ret)
+ goto err_role_put;
+ }
+
ret = devm_request_threaded_irq(&client->dev, client->irq, NULL,
tps6598x_interrupt,
IRQF_SHARED | IRQF_ONESHOT,
--
2.25.1
next prev parent reply other threads:[~2021-09-18 12:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 12:09 [RFT PATCH 0/9] usb: typec: tipd: Add Apple M1 support Sven Peter
2021-09-18 12:09 ` [RFT PATCH 1/9] dt-bindings: usb: tps6598x: Add Apple CD321x compatible Sven Peter
2021-09-19 11:25 ` Alyssa Rosenzweig
2021-09-22 20:38 ` Rob Herring
2021-09-18 12:09 ` [RFT PATCH 2/9] usb: typec: tipd: Prepare supporting different variants Sven Peter
2021-09-19 11:27 ` Alyssa Rosenzweig
2021-09-21 13:10 ` Heikki Krogerus
2021-09-22 14:55 ` Sven Peter
2021-09-18 12:09 ` [RFT PATCH 3/9] usb: typec: tipd: Allow irq controller selection Sven Peter
2021-09-19 11:28 ` Alyssa Rosenzweig
2021-09-21 13:21 ` Heikki Krogerus
2021-09-22 14:56 ` Sven Peter
2021-09-18 12:09 ` [RFT PATCH 4/9] usb: typec: tipd: Add short-circuit for no irqs Sven Peter
2021-09-21 13:23 ` Heikki Krogerus
2021-09-18 12:09 ` [RFT PATCH 5/9] usb: typec: tipd: Allow to configure irq bits Sven Peter
2021-09-21 13:34 ` Heikki Krogerus
2021-09-22 14:58 ` Sven Peter
2021-09-18 12:09 ` Sven Peter [this message]
2021-09-19 11:31 ` [RFT PATCH 6/9] usb: typec: tipd: Setup IntMask explicitly Alyssa Rosenzweig
2021-09-21 13:40 ` Heikki Krogerus
2021-09-22 14:58 ` Sven Peter
2021-09-18 12:09 ` [RFT PATCH 7/9] usb: typec: tipd: Add support for apple,cd321x Sven Peter
2021-09-19 11:32 ` Alyssa Rosenzweig
2021-09-18 12:09 ` [RFT PATCH 8/9] usb: typec: tipd: Switch power state to S0 for Apple variant Sven Peter
2021-09-19 11:33 ` Alyssa Rosenzweig
2021-09-21 13:46 ` Heikki Krogerus
2021-09-22 15:00 ` Sven Peter
2021-09-18 12:09 ` [RFT PATCH 9/9] usb: typec: tipd: Remove FIXME about testing with I2C_FUNC_I2C Sven Peter
2021-09-19 11:33 ` Alyssa Rosenzweig
2021-09-21 13:41 ` Heikki Krogerus
2021-09-19 11:35 ` [RFT PATCH 0/9] usb: typec: tipd: Add Apple M1 support Alyssa Rosenzweig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210918120934.28252-7-sven@svenpeter.dev \
--to=sven@svenpeter.dev \
--cc=agx@sigxcpu.org \
--cc=alyssa@rosenzweig.io \
--cc=bryan.odonoghue@linaro.org \
--cc=graf@amazon.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mark.kettenis@xs4all.nl \
--cc=mohamed.mediouni@caramail.com \
--cc=stan@corellium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome