From: Mark Brown <broonie@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Kirill Marinushkin" <kmarinushkin@birdec.com>
Subject: Re: [PATCH] ASoC: pcm512x: Mend accesses to the I2S_1 and I2S_2 registers
Date: Tue, 21 Sep 2021 13:01:13 +0100 [thread overview]
Message-ID: <20210921120113.GA9990@sirena.org.uk> (raw)
In-Reply-To: <8b96eb7b-8829-443f-481c-ab1772ece098@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Tue, Sep 21, 2021 at 10:48:01AM +0200, Peter Rosin wrote:
> On 2021-09-21 10:10, Peter Rosin wrote:
> Ok, so the attached works for me as well. But I don't know if it's
> appropriate to resume/suspend like that?
> is:
>
> pcm512x 0-004c: Failed to set data format: -16
>
> The root cause is that the chip is in Powerdown mode when
> pcm512x_set_fmt runs. So, bring the chip out of suspend for
> the update of the format.
How would this work if the device looses power while in suspend (eg, due
to the regulators being software controllable)? If the data isn't being
stored in the cache then it'll need to be stored somewhere else and
restored on resume.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-21 12:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 14:49 Peter Rosin
[not found] ` <ae4b25f1-2b2c-d937-e23d-0f7d23bdf0c4@gmail.com>
2021-09-20 19:37 ` Peter Rosin
2021-09-20 21:29 ` Mark Brown
2021-09-21 6:37 ` Peter Rosin
2021-09-21 11:11 ` Mark Brown
2021-09-21 4:20 ` Péter Ujfalusi
2021-09-21 6:52 ` Peter Rosin
2021-09-21 8:10 ` Peter Rosin
2021-09-21 8:48 ` Peter Rosin
2021-09-21 12:01 ` Mark Brown [this message]
2021-09-21 13:30 ` Peter Rosin
2021-09-21 15:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210921120113.GA9990@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kmarinushkin@birdec.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter.ujfalusi@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®