From: Mark Brown <broonie@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Takashi Iwai" <tiwai@suse.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Kirill Marinushkin" <kmarinushkin@birdec.com>
Subject: Re: [PATCH] ASoC: pcm512x: Mend accesses to the I2S_1 and I2S_2 registers
Date: Mon, 20 Sep 2021 22:29:18 +0100 [thread overview]
Message-ID: <YUj9LqNTH6A4CQcj@sirena.org.uk> (raw)
In-Reply-To: <815cbba4-60d6-8d97-c483-146c2f7c3912@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 806 bytes --]
On Mon, Sep 20, 2021 at 09:37:37PM +0200, Peter Rosin wrote:
> compare if the update was needed at all. But marking volatile wasn't
> enough. I also tried to set both a default and mark as volatile,
> but it seems every read fails with -16 (EBUSY). I don't get why, to me
> it almost feels like a regmap issue of some sort (probably the regmap
> config is bad in some way), but I'm not fluent in regmap...
Having a default for a volatile register isn't really a sensible
configuration since the whole point with volatile registers is
that they change underneath us, I'd not be surprised if we had
some error checking code in there that was trying to tell you
there was a problem though it does seem like it should at least
be more verbose about it since returning -EBUSY isn't exactly
helpful by itself.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-09-20 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 14:49 Peter Rosin
[not found] ` <ae4b25f1-2b2c-d937-e23d-0f7d23bdf0c4@gmail.com>
2021-09-20 19:37 ` Peter Rosin
2021-09-20 21:29 ` Mark Brown [this message]
2021-09-21 6:37 ` Peter Rosin
2021-09-21 11:11 ` Mark Brown
2021-09-21 4:20 ` Péter Ujfalusi
2021-09-21 6:52 ` Peter Rosin
2021-09-21 8:10 ` Peter Rosin
2021-09-21 8:48 ` Peter Rosin
2021-09-21 12:01 ` Mark Brown
2021-09-21 13:30 ` Peter Rosin
2021-09-21 15:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUj9LqNTH6A4CQcj@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=kmarinushkin@birdec.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=peter.ujfalusi@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®