From: Nicolai Stange <nstange@suse.de>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
"Stephan Müller" <smueller@chronox.de>,
"Torsten Duwe" <duwe@suse.de>, "Nicolai Stange" <nstange@suse.de>
Subject: [PATCH 0/8] crypto: api - priorize tested algorithms in lookup
Date: Sun, 3 Oct 2021 20:14:05 +0200 [thread overview]
Message-ID: <20211003181413.12465-1-nstange@suse.de> (raw)
Hi all,
my initial goal had been to make the algorithm lookup prefer usable
instances over ones where the tests are still pending. In my first attempt
I realized that the code in crypto_alg_lookup() became quite convoluted
and that it could get streamlined somewhat by consolidating
CRYPTO_ALG_TESTED handling for lookup larvals a bit.
This cleanup can be found in [1/8] - [7/8] and might perhaps be worth
considering on its own, independent of whether or not you deem the
final [8/8], the patch implementing my original goal of priorizing
algorithms in working state, suitable for upstream inclusion.
This series is based on current herbert/cryptodev-2.6 master.
All patches have been tested with tcrypt.ko as well as the kernel/crypto
testcases from LTP.
Thanks!
Nicolai
Nicolai Stange (8):
crypto: af_alg - reject requests for untested algorithms
crypto: user - reject requests for untested algorithms
crypto: api - only support lookups for specific CRYPTO_ALG_TESTED
status
crypto: api - don't add larvals for !(type & CRYPTO_ALG_TESTED)
lookups
crypto: api - always set CRYPTO_ALG_TESTED in lookup larvals'
->mask/type
crypto: api - make crypto_alg_lookup() consistently check for failed
algos
crypto: api - lift common mask + type adjustment to
crypto_larval_lookup()
crypto: api - make the algorithm lookup priorize non-larvals
crypto/af_alg.c | 9 +++++++
crypto/api.c | 53 ++++++++++++++++++++++++++++++++-------
crypto/crypto_user_base.c | 3 +++
3 files changed, 56 insertions(+), 9 deletions(-)
--
2.26.2
next reply other threads:[~2021-10-03 18:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 18:14 Nicolai Stange [this message]
2021-10-03 18:14 ` [PATCH 1/8] crypto: af_alg - reject requests for untested algorithms Nicolai Stange
2021-10-03 18:14 ` [PATCH 2/8] crypto: user " Nicolai Stange
2021-10-03 18:14 ` [PATCH 3/8] crypto: api - only support lookups for specific CRYPTO_ALG_TESTED status Nicolai Stange
2021-10-03 18:14 ` [PATCH 4/8] crypto: api - don't add larvals for !(type & CRYPTO_ALG_TESTED) lookups Nicolai Stange
2021-10-03 18:14 ` [PATCH 5/8] crypto: api - always set CRYPTO_ALG_TESTED in lookup larvals' ->mask/type Nicolai Stange
2021-10-03 18:14 ` [PATCH 6/8] crypto: api - make crypto_alg_lookup() consistently check for failed algos Nicolai Stange
2021-10-03 18:14 ` [PATCH 7/8] crypto: api - lift common mask + type adjustment to crypto_larval_lookup() Nicolai Stange
2021-10-03 18:14 ` [PATCH 8/8] crypto: api - make the algorithm lookup priorize non-larvals Nicolai Stange
2021-10-08 11:54 ` Herbert Xu
2021-10-11 8:34 ` Nicolai Stange
2021-10-22 11:51 ` Herbert Xu
2021-10-27 9:59 ` Nicolai Stange
2021-10-28 2:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211003181413.12465-1-nstange@suse.de \
--to=nstange@suse.de \
--cc=davem@davemloft.net \
--cc=duwe@suse.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=smueller@chronox.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®