mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: qcom: apq8096: Constify static snd_soc_ops
@ 2021-10-04 22:32 Rikard Falkeborn
  0 siblings, 0 replies; 3+ messages in thread
From: Rikard Falkeborn @ 2021-10-04 22:32 UTC (permalink / raw)
  To: Liam Girdwood, Mark Brown
  Cc: Srinivas Kandagatla, Banajit Goswami, Jaroslav Kysela,
	Takashi Iwai, alsa-devel, linux-kernel, Rikard Falkeborn

The struct iapq8096_ops is only assigned to the ops field in the
snd_soc_dai_link struct which is a pointer to const struct snd_soc_ops.
Make it const to allow the compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 sound/soc/qcom/apq8096.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c
index 1a69baefc5ce..c7b7d0864d1a 100644
--- a/sound/soc/qcom/apq8096.c
+++ b/sound/soc/qcom/apq8096.c
@@ -60,7 +60,7 @@ static int msm_snd_hw_params(struct snd_pcm_substream *substream,
 	return ret;
 }
 
-static struct snd_soc_ops apq8096_ops = {
+static const struct snd_soc_ops apq8096_ops = {
 	.hw_params = msm_snd_hw_params,
 };
 
-- 
2.33.0


^ permalink raw reply	[flat|nested] 3+ messages in thread
* [PATCH] ASoC: qcom: apq8096: Constify static snd_soc_ops
@ 2021-10-01 11:50 Rikard Falkeborn
  2021-10-02  0:16 ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Rikard Falkeborn @ 2021-10-01 11:50 UTC (permalink / raw)
  To: Srinivas Kandagatla, Banajit Goswami
  Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
	alsa-devel, linux-kernel, Rikard Falkeborn

The struct iapq8096_ops is only assigned to the ops field in the
snd_soc_dai_link struct which is a pointer to const struct snd_soc_ops.
Make it const to allow the compiler to put it in read-only memory.

Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
---
 sound/soc/qcom/apq8096.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c
index 1a69baefc5ce..c7b7d0864d1a 100644
--- a/sound/soc/qcom/apq8096.c
+++ b/sound/soc/qcom/apq8096.c
@@ -60,7 +60,7 @@ static int msm_snd_hw_params(struct snd_pcm_substream *substream,
 	return ret;
 }
 
-static struct snd_soc_ops apq8096_ops = {
+static const struct snd_soc_ops apq8096_ops = {
 	.hw_params = msm_snd_hw_params,
 };
 
-- 
2.33.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-04 22:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-04 22:32 [PATCH] ASoC: qcom: apq8096: Constify static snd_soc_ops Rikard Falkeborn
  -- strict thread matches above, loose matches on Subject: below --
2021-10-01 11:50 Rikard Falkeborn
2021-10-02  0:16 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®