From: "Paul E. McKenney" <paulmck@kernel.org>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: linux-kernel@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: data dependency naming inconsistency
Date: Thu, 14 Oct 2021 16:06:18 -0700 [thread overview]
Message-ID: <20211014230618.GL880162@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <8a9ea500-8f8c-129a-2974-4bdda65dbf64@gmail.com>
On Fri, Oct 15, 2021 at 07:48:09AM +0900, Akira Yokosawa wrote:
> On Thu, 14 Oct 2021 23:29:43 +0900, Akira Yokosawa wrote:
> > [-CC akys: my 2nd address]
> > On Thu, 14 Oct 2021 01:37:17 -0400, Michael S. Tsirkin wrote:
> >> On Thu, Oct 14, 2021 at 01:43:24PM +0900, Akira Yokosawa wrote:
> >>> On Mon, 11 Oct 2021 07:07:08 -0400, Michael S. Tsirkin wrote:
> >>>> Hello Paul, all!
> >>>
> >>> Hello Michael,
> >>>
> >>> I thought Paul would respond soon, but looks like he has not
> >>> done so.
>
> This is because Michael used Paul's old email address.
Indeed, my ibm.com email addresses died about two years ago.
> Forwarding to his current address.
>
> Paul, you can see the thread at the lore archive:
> https://lore.kernel.org/lkml/20211011064233-mutt-send-email-mst@kernel.org/T/
And thank you for forwarding this.
> Thanks, Akira
>
> >>> So, I'm trying to give some hint to your findings.
> >>>
> >>>> I've been reading with interest Paul's posts about Rust interactions with LKMM
> >>>> https://paulmck.livejournal.com/63316.html
> >>>> and in particular it states:
> >>>> A data dependency involves a load whose return value directly or
> >>>> indirectly determine the value stored by a later store, which results in
> >>>> the load being ordered before the store.
> >>>>
> >>>> This matches the perf book:
> >>>> A data dependency occurs when the value returned by
> >>>> a load instruction is used to compute the data stored by
> >>>> a later store instruction.
> >>>
> >>> You might likely be aware, but these concern "data dependency",
> >>> not a _barrier_.
> >>>
> >>>>
> >>>> however, memory-barriers.txt states:
> >>>>
> >>>> A data dependency barrier is a partial ordering on interdependent loads
> >>>> only; it is not required to have any effect on stores, independent loads
> >>>> or overlapping loads.
As noted by others, the difference is that the first two are about a
data dependency, that is a prior load affecting the value stored by
a later store. In contrast, the last one is about a data-dependency
barrier, which need only affect trailing loads. Trailing stores are
already covered by control dependencies. But clearer wording might
be good. Suggestions?
> >>>> It also says:
> >>>> A data-dependency barrier is not required to order dependent writes
> >>>> because the CPUs that the Linux kernel supports don't do writes
> >>>> until they are certain (1) that the write will actually happen, (2)
> >>>> of the location of the write, and (3) of the value to be written.
> >>>
> >>> These concern the historic "data-dependency barrier", or
> >>> [smp_]read_barrier_depends(), which existed until Linux kernel v4.14.
> >
> > Ah... I should have said ", which existed prior to Linux kernel v4.15".
> > This invited off-by-one error below...
> >
> >>>
> >>>>
> >>>> so the result it the same: writes are ordered without a barrier,
> >>>> reads are ordered by a barrier.
> >>>>
> >>>> However, it would seem that a bit more consistency in naming won't
> >>>> hurt.
> >>>
> >>> So, I don't think the historic term of "data-dependency barrier"
> >>> can be changed.
> >>>
> >>> I guess the right approach would be to further de-emphasize
> >>> "data-dependency barrier"/"data dependency barrier" in
> >>> memory-barriers.txt.
> >>>
> >>> Rewrite by commit 8ca924aeb4f2 ("Documentation/barriers: Remove
> >>> references to [smp_]read_barrier_depends()") did some of such
> >>> changes, but it failed to update the introductory section of
> >>> "VARIETIES OF MEMORY BARRIER".
> >>> The part Michael quoted above belongs to it.
> >>> I don't think it has any merit keeping it around.
> >>>
> >>> Also, there remain a couple of ascii-art diagrams concerning
> >>> <data dependency barrier> in the first part of "EXAMPLES OF MEMORY
> >>> BARRIER SEQUENCES" section, which, I think, can be removed as well.
> >>>
> >>> Hope this helps clarify the circumstances.
> >>
> >> It does, thanks! It might be worth adding a sentence along the lines of
> >>
> >> "NB: a data dependency barrier is distinct from a data dependency: it's
> >> a barrier that used to be required in the presence of a data dependency.
> >> Since v4.14 Linux no longer offers an API for a data dependency barrier.
> >
> > Since v4.15
> >
> >> Instead, using READ_ONCE is sufficient for ordering in the presence of a
> >> data dependency".
> >
> >
> > Maybe.
> >
> > But I'm more inclined to get rid of remaining contents related to the
> > "data dependency barrier".
Given that we don't seem to have any more data-dependency barriers,
so getting rid of remaining mentions makes a lot of sense to me.
Thanx, Paul
> > Thanks, Akira
> >
> >>
> >>
> >>> Paul, what is your take on the naming of "data dependency"/
> >>> "data dependency barrier"?
> >>>
> >>> Thanks, Akira
> >>>
> >>>>
> >>>> Thanks,
> >>>>
> >>>> --
> >>>> MST
> >>
prev parent reply other threads:[~2021-10-14 23:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 11:07 Michael S. Tsirkin
2021-10-14 4:43 ` Akira Yokosawa
2021-10-14 5:37 ` Michael S. Tsirkin
2021-10-14 14:29 ` Akira Yokosawa
2021-10-14 16:06 ` Michael S. Tsirkin
2021-10-14 22:48 ` Akira Yokosawa
2021-10-14 23:06 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014230618.GL880162@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=akiyks@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®