* [PATCH] ASoC: amd: vangogh: add SPI dependency
@ 2021-10-19 19:14 Arnd Bergmann
2021-11-03 16:15 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2021-10-19 19:14 UTC (permalink / raw)
To: Mark Brown
Cc: Arnd Bergmann, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Vijendar Mukunda, Pierre-Louis Bossart, Ajit Kumar Pandey,
alsa-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Without CONFIG_SPI, this fails to build:
WARNING: unmet direct dependencies detected for SND_SOC_CS35L41_SPI
Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SPI_MASTER [=n]
Selected by [m]:
- SND_SOC_AMD_VANGOGH_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_AMD_ACP5x [=m] && I2C [=y]
ERROR: modpost: "spi_setup" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined!
ERROR: modpost: "__devm_regmap_init_spi" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined!
Fixes: 96792fdd77cd ("ASoC: amd: enable vangogh platform machine driver build")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
sound/soc/amd/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
index d91a9399777c..edee2098c82e 100644
--- a/sound/soc/amd/Kconfig
+++ b/sound/soc/amd/Kconfig
@@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH
tristate "AMD Vangogh support for NAU8821 CS35L41"
select SND_SOC_NAU8821
select SND_SOC_CS35L41_SPI
- depends on SND_SOC_AMD_ACP5x && I2C
+ depends on SND_SOC_AMD_ACP5x && I2C && SPI
help
This option enables machine driver for Vangogh platform
using NAU8821 and CS35L41 codecs.
--
2.29.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] ASoC: amd: vangogh: add SPI dependency
2021-10-19 19:14 [PATCH] ASoC: amd: vangogh: add SPI dependency Arnd Bergmann
@ 2021-11-03 16:15 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2021-11-03 16:15 UTC (permalink / raw)
To: Arnd Bergmann, Mark Brown
Cc: Arnd Bergmann, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
Vijendar Mukunda, Pierre-Louis Bossart, Ajit Kumar Pandey,
alsa-devel, linux-kernel
On 10/19/21 12:14 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without CONFIG_SPI, this fails to build:
>
> WARNING: unmet direct dependencies detected for SND_SOC_CS35L41_SPI
> Depends on [n]: SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SPI_MASTER [=n]
> Selected by [m]:
> - SND_SOC_AMD_VANGOGH_MACH [=m] && SOUND [=m] && !UML && SND [=m] && SND_SOC [=m] && SND_SOC_AMD_ACP5x [=m] && I2C [=y]
> ERROR: modpost: "spi_setup" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined!
> ERROR: modpost: "__devm_regmap_init_spi" [sound/soc/codecs/snd-soc-cs35l41-spi.ko] undefined!
>
> Fixes: 96792fdd77cd ("ASoC: amd: enable vangogh platform machine driver build")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/amd/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig
> index d91a9399777c..edee2098c82e 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -68,7 +68,7 @@ config SND_SOC_AMD_VANGOGH_MACH
> tristate "AMD Vangogh support for NAU8821 CS35L41"
> select SND_SOC_NAU8821
> select SND_SOC_CS35L41_SPI
> - depends on SND_SOC_AMD_ACP5x && I2C
> + depends on SND_SOC_AMD_ACP5x && I2C && SPI
> help
> This option enables machine driver for Vangogh platform
> using NAU8821 and CS35L41 codecs.
>
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Just had this build error in linux-next-20211103
so this patch is needed there.
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-03 16:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-19 19:14 [PATCH] ASoC: amd: vangogh: add SPI dependency Arnd Bergmann
2021-11-03 16:15 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®