From: Leo Yan <leo.yan@linaro.org>
To: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kees Cook <keescook@chromium.org>,
Ard Biesheuvel <ardb@kernel.org>,
Sami Tolvanen <samitolvanen@google.com>,
Nicholas Piggin <npiggin@gmail.com>,
James Morse <james.morse@arm.com>, Marc Zyngier <maz@kernel.org>,
Joey Gouly <joey.gouly@arm.com>,
Peter Collingbourne <pcc@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
James Clark <james.clark@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Leo Yan <leo.yan@linaro.org>
Subject: [RFCv1 4/4] perf: arm_spe: Dynamically switch PID tracing to contextidr
Date: Thu, 21 Oct 2021 21:45:30 +0800 [thread overview]
Message-ID: <20211021134530.206216-5-leo.yan@linaro.org> (raw)
In-Reply-To: <20211021134530.206216-1-leo.yan@linaro.org>
Now Arm64 provides API for enabling and disable PID tracing, Arm SPE
driver invokes these functions to dynamically enable it during
profiling when the program runs in root PID name space, and disable PID
tracing when the perf event is stopped.
Device drivers should not depend on CONFIG_PID_IN_CONTEXTIDR for PID
tracing, so this patch uses the consistent condition for setting bit
EL1_CX for PMSCR.
Signed-off-by: Leo Yan <leo.yan@linaro.org>
---
drivers/perf/arm_spe_pmu.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c
index d44bcc29d99c..935343cdcb39 100644
--- a/drivers/perf/arm_spe_pmu.c
+++ b/drivers/perf/arm_spe_pmu.c
@@ -23,6 +23,7 @@
#include <linux/irq.h>
#include <linux/kernel.h>
#include <linux/list.h>
+#include <linux/mmu_context.h>
#include <linux/module.h>
#include <linux/of_address.h>
#include <linux/of_device.h>
@@ -272,7 +273,7 @@ static u64 arm_spe_event_to_pmscr(struct perf_event *event)
if (!attr->exclude_kernel)
reg |= BIT(SYS_PMSCR_EL1_E1SPE_SHIFT);
- if (IS_ENABLED(CONFIG_PID_IN_CONTEXTIDR) && perfmon_capable())
+ if (perfmon_capable() && (task_active_pid_ns(current) == &init_pid_ns))
reg |= BIT(SYS_PMSCR_EL1_CX_SHIFT);
return reg;
@@ -731,6 +732,13 @@ static void arm_spe_pmu_start(struct perf_event *event, int flags)
if (hwc->state)
return;
+ /*
+ * Enable tracing PID to contextidr if profiling program runs in
+ * root PID namespace.
+ */
+ if (perfmon_capable() && (task_active_pid_ns(current) == &init_pid_ns))
+ contextidr_enable();
+
reg = arm_spe_event_to_pmsfcr(event);
write_sysreg_s(reg, SYS_PMSFCR_EL1);
@@ -792,6 +800,9 @@ static void arm_spe_pmu_stop(struct perf_event *event, int flags)
}
hwc->state |= PERF_HES_STOPPED;
+
+ if (perfmon_capable() && (task_active_pid_ns(current) == &init_pid_ns))
+ contextidr_disable();
}
static int arm_spe_pmu_add(struct perf_event *event, int flags)
--
2.25.1
next prev parent reply other threads:[~2021-10-21 13:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 13:45 [RFCv1 0/4] arm64: Use static key for PID in CONTEXTIDR Leo Yan
2021-10-21 13:45 ` [RFCv1 1/4] arm64: Use static key for tracing " Leo Yan
2021-10-21 14:33 ` James Clark
2021-10-21 14:37 ` Leo Yan
2021-10-21 15:47 ` Kees Cook
2021-10-21 13:45 ` [RFCv1 2/4] arm64: entry: Always apply workaround for contextidr_el1 Leo Yan
2021-10-21 13:45 ` [RFCv1 3/4] arm64: Introduce functions for controlling PID tracing Leo Yan
2021-10-21 13:45 ` Leo Yan [this message]
2021-10-21 15:49 ` [RFCv1 4/4] perf: arm_spe: Dynamically switch PID tracing to contextidr Kees Cook
2021-10-22 2:09 ` Leo Yan
2021-11-01 15:28 ` Leo Yan
2021-12-03 16:22 ` Catalin Marinas
2021-12-05 13:51 ` Leo Yan
2021-12-07 11:48 ` Catalin Marinas
2021-12-07 12:31 ` Leo Yan
2021-12-08 17:29 ` Catalin Marinas
2021-12-10 7:59 ` Leo Yan
2021-12-17 7:58 ` Leo Yan
2022-01-17 18:48 ` Catalin Marinas
2022-02-01 13:02 ` Leo Yan
2021-10-22 15:36 ` James Clark
2021-10-22 15:40 ` James Clark
2021-10-22 16:23 ` James Clark
2021-10-24 10:25 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021134530.206216-5-leo.yan@linaro.org \
--to=leo.yan@linaro.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=eranian@google.com \
--cc=james.clark@arm.com \
--cc=james.morse@arm.com \
--cc=joey.gouly@arm.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=npiggin@gmail.com \
--cc=pcc@google.com \
--cc=peterz@infradead.org \
--cc=samitolvanen@google.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®