From: Sam Protsenko <semen.protsenko@linaro.org>
To: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH 5/7] watchdog: s3c2410: Introduce separate source clock
Date: Thu, 28 Oct 2021 21:35:25 +0300 [thread overview]
Message-ID: <20211028183527.3050-6-semen.protsenko@linaro.org> (raw)
In-Reply-To: <20211028183527.3050-1-semen.protsenko@linaro.org>
Some Exynos chips (like Exynos850) have dedicated source clock. That
clock is provided from device tree as "watchdog_src" clock. In such
case, "watchdog" clock is just a peripheral clock used for register
interface. If "watchdog_src" is present, use its rate instead of
"watchdog" for all timer related calculations.
Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
drivers/watchdog/s3c2410_wdt.c | 33 +++++++++++++++++++++++++++------
1 file changed, 27 insertions(+), 6 deletions(-)
diff --git a/drivers/watchdog/s3c2410_wdt.c b/drivers/watchdog/s3c2410_wdt.c
index a5ef7171a90e..bfc5872ca497 100644
--- a/drivers/watchdog/s3c2410_wdt.c
+++ b/drivers/watchdog/s3c2410_wdt.c
@@ -126,6 +126,8 @@ struct s3c2410_wdt_variant {
struct s3c2410_wdt {
struct device *dev;
struct clk *clock;
+ struct clk *clock_src;
+ unsigned long freq_src;
void __iomem *reg_base;
unsigned int count;
spinlock_t lock;
@@ -213,10 +215,8 @@ MODULE_DEVICE_TABLE(platform, s3c2410_wdt_ids);
/* functions */
-static inline unsigned int s3c2410wdt_max_timeout(struct clk *clock)
+static inline unsigned int s3c2410wdt_max_timeout(unsigned long freq)
{
- unsigned long freq = clk_get_rate(clock);
-
return S3C2410_WTCNT_MAXCNT / (freq / (S3C2410_WTCON_PRESCALE_MAX + 1)
/ S3C2410_WTCON_MAXDIV);
}
@@ -364,7 +364,7 @@ static int s3c2410wdt_set_heartbeat(struct watchdog_device *wdd,
unsigned int timeout)
{
struct s3c2410_wdt *wdt = watchdog_get_drvdata(wdd);
- unsigned long freq = clk_get_rate(wdt->clock);
+ unsigned long freq = wdt->freq_src;
unsigned int count;
unsigned int divisor = 1;
unsigned long wtcon;
@@ -627,13 +627,27 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
return ret;
}
+ /* "watchdog_src" clock is optional; if it's not present -- just skip */
+ wdt->clock_src = devm_clk_get(dev, "watchdog_src");
+ if (!IS_ERR(wdt->clock_src)) {
+ ret = clk_prepare_enable(wdt->clock_src);
+ if (ret < 0) {
+ dev_err(dev, "failed to enable source clock\n");
+ ret = PTR_ERR(wdt->clock_src);
+ goto err_clk;
+ }
+ wdt->freq_src = clk_get_rate(wdt->clock_src);
+ } else {
+ wdt->freq_src = clk_get_rate(wdt->clock);
+ }
+
wdt->wdt_device.min_timeout = 1;
- wdt->wdt_device.max_timeout = s3c2410wdt_max_timeout(wdt->clock);
+ wdt->wdt_device.max_timeout = s3c2410wdt_max_timeout(wdt->freq_src);
ret = s3c2410wdt_cpufreq_register(wdt);
if (ret < 0) {
dev_err(dev, "failed to register cpufreq\n");
- goto err_clk;
+ goto err_clk_src;
}
watchdog_set_drvdata(&wdt->wdt_device, wdt);
@@ -707,6 +721,10 @@ static int s3c2410wdt_probe(struct platform_device *pdev)
err_cpufreq:
s3c2410wdt_cpufreq_deregister(wdt);
+ err_clk_src:
+ if (!IS_ERR(wdt->clock_src))
+ clk_disable_unprepare(wdt->clock_src);
+
err_clk:
clk_disable_unprepare(wdt->clock);
@@ -727,6 +745,9 @@ static int s3c2410wdt_remove(struct platform_device *dev)
s3c2410wdt_cpufreq_deregister(wdt);
+ if (!IS_ERR(wdt->clock_src))
+ clk_disable_unprepare(wdt->clock_src);
+
clk_disable_unprepare(wdt->clock);
return 0;
--
2.30.2
next prev parent reply other threads:[~2021-10-28 18:35 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 18:35 [PATCH 0/7] watchdog: s3c2410: Add Exynos850 support Sam Protsenko
2021-10-28 18:35 ` [PATCH 1/7] dt-bindings: watchdog: Require samsung,syscon-phandle for Exynos7 Sam Protsenko
2021-10-29 7:55 ` Krzysztof Kozlowski
2021-10-28 18:35 ` [PATCH 2/7] dt-bindings: watchdog: Document Exynos850 watchdog bindings Sam Protsenko
2021-10-29 8:02 ` Krzysztof Kozlowski
2021-10-29 17:48 ` Sam Protsenko
2021-10-28 18:35 ` [PATCH 3/7] watchdog: s3c2410: Make reset disable optional Sam Protsenko
2021-10-29 0:16 ` Guenter Roeck
2021-10-29 8:04 ` Krzysztof Kozlowski
2021-10-29 19:25 ` Sam Protsenko
2021-10-29 19:23 ` Sam Protsenko
2021-10-28 18:35 ` [PATCH 4/7] watchdog: s3c2410: Add support for WDT counter enable Sam Protsenko
2021-10-29 0:16 ` Guenter Roeck
2021-10-29 20:44 ` Sam Protsenko
2021-10-28 18:35 ` Sam Protsenko [this message]
2021-10-29 0:21 ` [PATCH 5/7] watchdog: s3c2410: Introduce separate source clock Guenter Roeck
2021-10-30 12:39 ` Sam Protsenko
2021-10-29 8:18 ` Krzysztof Kozlowski
2021-10-30 14:12 ` Sam Protsenko
2021-10-28 18:35 ` [PATCH 6/7] watchdog: s3c2410: Add Exynos850 support Sam Protsenko
2021-10-28 18:35 ` [PATCH 7/7] watchdog: s3c2410: Let kernel kick watchdog Sam Protsenko
2021-10-29 0:30 ` Guenter Roeck
2021-10-30 14:29 ` Sam Protsenko
2021-10-30 15:14 ` Guenter Roeck
2021-10-30 16:59 ` Sam Protsenko
2021-10-30 17:47 ` Guenter Roeck
2021-10-30 19:25 ` Sam Protsenko
2021-10-29 8:20 ` Krzysztof Kozlowski
2021-10-30 14:59 ` Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028183527.3050-6-semen.protsenko@linaro.org \
--to=semen.protsenko@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®