* [PATCH] cpuidle: fix unmet dependencies on ARCH_SUSPEND_POSSIBLE for ARM_CPU_SUSPEND
@ 2021-10-29 21:52 Julian Braha
2021-11-05 15:26 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Julian Braha @ 2021-10-29 21:52 UTC (permalink / raw)
To: rafael, daniel.lezcano; +Cc: linux-pm, linux-kernel, fazilyildiran
When ARM_TEGRA_CPUIDLE or ARM_QCOM_SPM_CPUIDLE are selected,
and ARCH_SUSPEND_POSSIBLE is disabled, Kbuild gives the
following warnings:
WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
Selected by [y]:
- ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
and
WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
Selected by [y]:
- ARM_QCOM_SPM_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
This is because these options enable ARM_CPU_SUSPEND
without selecting or depending on ARCH_SUSPEND_POSSIBLE,
despite ARM_CPU_SUSPEND depending on ARCH_SUSPEND_POSSIBLE.
These unmet dependency bugs were detected by Kismet,
a static analysis tool for Kconfig. Please advise if
this is not the appropriate solution.
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
drivers/cpuidle/Kconfig.arm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
index 15d6c46c0a47..1b4f5ae1ee05 100644
--- a/drivers/cpuidle/Kconfig.arm
+++ b/drivers/cpuidle/Kconfig.arm
@@ -100,6 +100,7 @@ config ARM_MVEBU_V7_CPUIDLE
config ARM_TEGRA_CPUIDLE
bool "CPU Idle Driver for NVIDIA Tegra SoCs"
depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU
+ depends on ARCH_SUSPEND_POSSIBLE
select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
select ARM_CPU_SUSPEND
help
@@ -108,6 +109,7 @@ config ARM_TEGRA_CPUIDLE
config ARM_QCOM_SPM_CPUIDLE
bool "CPU Idle Driver for Qualcomm Subsystem Power Manager (SPM)"
depends on (ARCH_QCOM || COMPILE_TEST) && !ARM64 && MMU
+ depends on ARCH_SUSPEND_POSSIBLE
select ARM_CPU_SUSPEND
select CPU_IDLE_MULTIPLE_DRIVERS
select DT_IDLE_STATES
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cpuidle: fix unmet dependencies on ARCH_SUSPEND_POSSIBLE for ARM_CPU_SUSPEND
2021-10-29 21:52 [PATCH] cpuidle: fix unmet dependencies on ARCH_SUSPEND_POSSIBLE for ARM_CPU_SUSPEND Julian Braha
@ 2021-11-05 15:26 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2021-11-05 15:26 UTC (permalink / raw)
To: Julian Braha
Cc: Rafael J. Wysocki, Daniel Lezcano, Linux PM,
Linux Kernel Mailing List, Necip Fazil Yildiran
On Fri, Oct 29, 2021 at 11:52 PM Julian Braha <julianbraha@gmail.com> wrote:
>
> When ARM_TEGRA_CPUIDLE or ARM_QCOM_SPM_CPUIDLE are selected,
> and ARCH_SUSPEND_POSSIBLE is disabled, Kbuild gives the
> following warnings:
>
> WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
> Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
> Selected by [y]:
> - ARM_TEGRA_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_TEGRA [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
>
> and
>
> WARNING: unmet direct dependencies detected for ARM_CPU_SUSPEND
> Depends on [n]: ARCH_SUSPEND_POSSIBLE [=n]
> Selected by [y]:
> - ARM_QCOM_SPM_CPUIDLE [=y] && CPU_IDLE [=y] && (ARM [=y] || ARM64) && (ARCH_QCOM [=n] || COMPILE_TEST [=y]) && !ARM64 && MMU [=y]
>
> This is because these options enable ARM_CPU_SUSPEND
> without selecting or depending on ARCH_SUSPEND_POSSIBLE,
> despite ARM_CPU_SUSPEND depending on ARCH_SUSPEND_POSSIBLE.
>
> These unmet dependency bugs were detected by Kismet,
> a static analysis tool for Kconfig. Please advise if
> this is not the appropriate solution.
The changes make sense to me, but I need the maintainers of the two
affected platforms to tell me that this is OK.
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
> ---
> drivers/cpuidle/Kconfig.arm | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
> index 15d6c46c0a47..1b4f5ae1ee05 100644
> --- a/drivers/cpuidle/Kconfig.arm
> +++ b/drivers/cpuidle/Kconfig.arm
> @@ -100,6 +100,7 @@ config ARM_MVEBU_V7_CPUIDLE
> config ARM_TEGRA_CPUIDLE
> bool "CPU Idle Driver for NVIDIA Tegra SoCs"
> depends on (ARCH_TEGRA || COMPILE_TEST) && !ARM64 && MMU
> + depends on ARCH_SUSPEND_POSSIBLE
> select ARCH_NEEDS_CPU_IDLE_COUPLED if SMP
> select ARM_CPU_SUSPEND
> help
> @@ -108,6 +109,7 @@ config ARM_TEGRA_CPUIDLE
> config ARM_QCOM_SPM_CPUIDLE
> bool "CPU Idle Driver for Qualcomm Subsystem Power Manager (SPM)"
> depends on (ARCH_QCOM || COMPILE_TEST) && !ARM64 && MMU
> + depends on ARCH_SUSPEND_POSSIBLE
> select ARM_CPU_SUSPEND
> select CPU_IDLE_MULTIPLE_DRIVERS
> select DT_IDLE_STATES
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-05 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-29 21:52 [PATCH] cpuidle: fix unmet dependencies on ARCH_SUSPEND_POSSIBLE for ARM_CPU_SUSPEND Julian Braha
2021-11-05 15:26 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®