* [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak
@ 2021-11-05 20:20 Rob Clark
2021-11-05 20:26 ` Doug Anderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rob Clark @ 2021-11-05 20:20 UTC (permalink / raw)
To: dri-devel
Cc: linux-arm-msm, freedreno, Steev Klimaszewski, Rob Clark,
Douglas Anderson, Rob Clark, Sean Paul, David Airlie,
Daniel Vetter, open list
From: Rob Clark <robdclark@chromium.org>
Reported-by: Douglas Anderson <dianders@chromium.org>
Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
index d32b729b4616..07f1169df89b 100644
--- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
+++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
@@ -20,6 +20,10 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
struct msm_gpu *gpu = dev_to_gpu(dev);
struct dev_pm_opp *opp;
+ /*
+ * Note that devfreq_recommended_opp() can modify the freq
+ * to something that actually is in the opp table:
+ */
opp = devfreq_recommended_opp(dev, freq, flags);
/*
@@ -28,6 +32,7 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
*/
if (gpu->devfreq.idle_freq) {
gpu->devfreq.idle_freq = *freq;
+ dev_pm_opp_put(opp);
return 0;
}
--
2.31.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak
2021-11-05 20:20 [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak Rob Clark
@ 2021-11-05 20:26 ` Doug Anderson
2021-11-05 20:29 ` Steev Klimaszewski
2021-11-05 21:34 ` Akhil P Oommen
2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2021-11-05 20:26 UTC (permalink / raw)
To: Rob Clark
Cc: dri-devel, linux-arm-msm, freedreno, Steev Klimaszewski,
Rob Clark, Sean Paul, David Airlie, Daniel Vetter, open list
Hi,
On Fri, Nov 5, 2021 at 1:15 PM Rob Clark <robdclark@gmail.com> wrote:
>
> From: Rob Clark <robdclark@chromium.org>
>
> Reported-by: Douglas Anderson <dianders@chromium.org>
> Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak
2021-11-05 20:20 [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak Rob Clark
2021-11-05 20:26 ` Doug Anderson
@ 2021-11-05 20:29 ` Steev Klimaszewski
2021-11-05 21:34 ` Akhil P Oommen
2 siblings, 0 replies; 4+ messages in thread
From: Steev Klimaszewski @ 2021-11-05 20:29 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: linux-arm-msm, freedreno, Rob Clark, Douglas Anderson, Sean Paul,
David Airlie, Daniel Vetter, open list
On 11/5/21 3:20 PM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Reported-by: Douglas Anderson <dianders@chromium.org>
> Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> index d32b729b4616..07f1169df89b 100644
> --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> @@ -20,6 +20,10 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
> struct msm_gpu *gpu = dev_to_gpu(dev);
> struct dev_pm_opp *opp;
>
> + /*
> + * Note that devfreq_recommended_opp() can modify the freq
> + * to something that actually is in the opp table:
> + */
> opp = devfreq_recommended_opp(dev, freq, flags);
>
> /*
> @@ -28,6 +32,7 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
> */
> if (gpu->devfreq.idle_freq) {
> gpu->devfreq.idle_freq = *freq;
> + dev_pm_opp_put(opp);
> return 0;
> }
>
Tested on the Lenovo Yoga C630 and don't see the message from v1 :D
Tested-By: Steev Klimaszewski <steev@kali.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak
2021-11-05 20:20 [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak Rob Clark
2021-11-05 20:26 ` Doug Anderson
2021-11-05 20:29 ` Steev Klimaszewski
@ 2021-11-05 21:34 ` Akhil P Oommen
2 siblings, 0 replies; 4+ messages in thread
From: Akhil P Oommen @ 2021-11-05 21:34 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: Rob Clark, David Airlie, linux-arm-msm, Douglas Anderson,
Steev Klimaszewski, open list, Sean Paul, freedreno
On 11/6/2021 1:50 AM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Reported-by: Douglas Anderson <dianders@chromium.org>
> Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> index d32b729b4616..07f1169df89b 100644
> --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> @@ -20,6 +20,10 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
> struct msm_gpu *gpu = dev_to_gpu(dev);
> struct dev_pm_opp *opp;
>
> + /*
> + * Note that devfreq_recommended_opp() can modify the freq
> + * to something that actually is in the opp table:
> + */
> opp = devfreq_recommended_opp(dev, freq, flags);
>
> /*
> @@ -28,6 +32,7 @@ static int msm_devfreq_target(struct device *dev, unsigned long *freq,
> */
> if (gpu->devfreq.idle_freq) {
> gpu->devfreq.idle_freq = *freq;
> + dev_pm_opp_put(opp);
> return 0;
> }
>
>
Reviewed-by: Akhil P Oommen <akhilpo@codeaurora.org>
-Akhil
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-05 21:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-05 20:20 [PATCH v2] drm/msm/devfreq: Fix OPP refcnt leak Rob Clark
2021-11-05 20:26 ` Doug Anderson
2021-11-05 20:29 ` Steev Klimaszewski
2021-11-05 21:34 ` Akhil P Oommen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®