From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org, Paul Mundt <lethal@linux-sh.org>
Subject: [PATCH 1/2] sh: mcount.S: fix build error when PRINTK is not enabled
Date: Sun, 14 Nov 2021 22:41:28 -0800 [thread overview]
Message-ID: <20211115064128.9896-1-rdunlap@infradead.org> (raw)
Fix a build error in mcount.S when CONFIG_PRINTK is not enabled.
Fixes this build error:
sh2-linux-ld: arch/sh/lib/mcount.o: in function `stack_panic':
(.text+0xec): undefined reference to `dump_stack'
Fixes: e460ab27b6c3e ("sh: Fix up stack overflow check with ftrace disabled.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Rich Felker <dalias@libc.org>
Cc: linux-sh@vger.kernel.org
Cc: Paul Mundt <lethal@linux-sh.org>
---
Possibly even more of this function should conditionally not be built...
arch/sh/lib/mcount.S | 4 ++++
1 file changed, 4 insertions(+)
--- linux-next-20211112.orig/arch/sh/lib/mcount.S
+++ linux-next-20211112/arch/sh/lib/mcount.S
@@ -257,9 +257,11 @@ return_to_handler:
#ifdef CONFIG_STACK_DEBUG
.globl stack_panic
stack_panic:
+#ifdef CONFIG_PRINTK
mov.l .Ldump_stack, r0
jsr @r0
nop
+#endif
mov.l .Lpanic, r0
jsr @r0
@@ -277,8 +279,10 @@ stack_panic:
.long panic
.Lpanic_s:
.long .Lpanic_str
+#ifdef CONFIG_PRINTK
.Ldump_stack:
.long dump_stack
+#endif
.section .rodata
.align 2
next reply other threads:[~2021-11-15 6:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 6:41 Randy Dunlap [this message]
2021-11-15 10:10 ` Geert Uytterhoeven
2021-11-16 2:48 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115064128.9896-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=dalias@libc.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®