From: Randy Dunlap <rdunlap@infradead.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH 1/2] sh: mcount.S: fix build error when PRINTK is not enabled
Date: Mon, 15 Nov 2021 18:48:39 -0800 [thread overview]
Message-ID: <7d54befc-496c-2035-a817-dd7ff74e5bf8@infradead.org> (raw)
In-Reply-To: <CAMuHMdULwWi6hEUGY7vA3Nc7DhYLp_dH0o-sVdijWg6Z54GijQ@mail.gmail.com>
On 11/15/21 2:10 AM, Geert Uytterhoeven wrote:
> Hi Randy,
>
> On Mon, Nov 15, 2021 at 7:41 AM Randy Dunlap <rdunlap@infradead.org> wrote:
>> Fix a build error in mcount.S when CONFIG_PRINTK is not enabled.
>> Fixes this build error:
>>
>> sh2-linux-ld: arch/sh/lib/mcount.o: in function `stack_panic':
>> (.text+0xec): undefined reference to `dump_stack'
>>
>> Fixes: e460ab27b6c3e ("sh: Fix up stack overflow check with ftrace disabled.")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks for your patch!
>
>> Possibly even more of this function should conditionally not be built...
>
> What about making STACK_DEBUG depend on PRINTK instead?
> It doesn't make much sense to enable the former, if you won't print
> any output...
Hi Geert,
That works. Thanks for the suggestion.
I'll send a v2.
--
~Randy
prev parent reply other threads:[~2021-11-16 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 6:41 Randy Dunlap
2021-11-15 10:10 ` Geert Uytterhoeven
2021-11-16 2:48 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d54befc-496c-2035-a817-dd7ff74e5bf8@infradead.org \
--to=rdunlap@infradead.org \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®