[PATCH] block: Use REQ_OP_WRITE instead of its integer constant 1 in op_is_write()

[PATCH] block: Use REQ_OP_WRITE instead of its integer constant 1 in op_is_write()

[Bean Huo]

From: Bean Huo <beanhuo@micron.com>

Use the enums REQ_OP_WRITE in op_is_write() to make it less maintenance
requirement and more readable

Signed-off-by: Bean Huo <beanhuo@micron.com>
---
 include/linux/blk_types.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index fe065c394fff..5b5924a7e754 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -463,7 +463,7 @@ static inline void bio_set_op_attrs(struct bio *bio, unsigned op,
 
 static inline bool op_is_write(unsigned int op)
 {
-	return (op & 1);
+	return (op & REQ_OP_WRITE);
 }
 
 /*
-- 
2.25.1

Re: [PATCH] block: Use REQ_OP_WRITE instead of its integer constant 1 in op_is_write()

[Chaitanya Kulkarni]

Bean,

>   static inline bool op_is_write(unsigned int op)
>   {
> -       return (op & 1);
> +       return (op & REQ_OP_WRITE);
>   }

As pointed out by Damien it supposed to indicate data out and not
only write request REQ_OP_WRITE.

> 
>   /*
> --
> 2.25.1
>