[PATCH] pcmcia: remvoe unneeded variable

[PATCH] pcmcia: remvoe unneeded variable

[cgel.zte]

From: ran jianping <ran.jianping@zte.com.cn>

Fix the following coccicheck review:
drivers/pcmcia/pcmcia_resource.c:396:5-8: Unneeded variable

Remove unneeded variable used to store return value.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
 drivers/pcmcia/pcmcia_resource.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
index c1c197292111..d7e0f659d0a7 100644
--- a/drivers/pcmcia/pcmcia_resource.c
+++ b/drivers/pcmcia/pcmcia_resource.c
@@ -393,7 +393,6 @@ int pcmcia_release_configuration(struct pcmcia_device *p_dev)
 static int pcmcia_release_io(struct pcmcia_device *p_dev)
 {
 	struct pcmcia_socket *s = p_dev->socket;
-	int ret = -EINVAL;
 	config_t *c;
 
 	mutex_lock(&s->ops_mutex);
@@ -413,7 +412,7 @@ static int pcmcia_release_io(struct pcmcia_device *p_dev)
 out:
 	mutex_unlock(&s->ops_mutex);
 
-	return ret;
+	return -EINVAL;
 } /* pcmcia_release_io */
 
 
-- 
2.25.1

Re: [PATCH] pcmcia: remvoe unneeded variable

[Dominik Brodowski]

Am Tue, Nov 16, 2021 at 02:33:10AM +0000 schrieb cgel.zte@gmail.com:
> From: ran jianping <ran.jianping@zte.com.cn>
> 
> Fix the following coccicheck review:
> drivers/pcmcia/pcmcia_resource.c:396:5-8: Unneeded variable
> 
> Remove unneeded variable used to store return value.
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
> ---
>  drivers/pcmcia/pcmcia_resource.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
> index c1c197292111..d7e0f659d0a7 100644
> --- a/drivers/pcmcia/pcmcia_resource.c
> +++ b/drivers/pcmcia/pcmcia_resource.c
> @@ -393,7 +393,6 @@ int pcmcia_release_configuration(struct pcmcia_device *p_dev)
>  static int pcmcia_release_io(struct pcmcia_device *p_dev)
>  {
>  	struct pcmcia_socket *s = p_dev->socket;
> -	int ret = -EINVAL;
>  	config_t *c;
>  
>  	mutex_lock(&s->ops_mutex);
> @@ -413,7 +412,7 @@ static int pcmcia_release_io(struct pcmcia_device *p_dev)
>  out:
>  	mutex_unlock(&s->ops_mutex);
>  
> -	return ret;
> +	return -EINVAL;
>  } /* pcmcia_release_io */

Thanks for your patch. It truly points out that the return value is unused,
and in fact, the sole caller does not check it. Therefore, it seems better
to remove the return value altogether, and convert it to type void.

Thanks,
	Dominik