From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Lucas Tanure <tanureal@opensource.cirrus.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Mark Brown <broonie@kernel.org>,
Takashi Iwai <tiwai@suse.com>, Kailang Yang <kailang@realtek.com>,
Shuming Fan <shumingf@realtek.com>,
"Pierre-Louis Bossart" <pierre-louis.bossart@linux.intel.com>,
David Rhodes <david.rhodes@cirrus.com>,
Vitaly Rodionov <vitalyr@opensource.cirrus.com>,
Jeremy Szu <jeremy.szu@canonical.com>,
Hui Wang <hui.wang@canonical.com>,
Werner Sembach <wse@tuxedocomputers.com>,
Chris Chiu <chris.chiu@canonical.com>,
Cameron Berkenpas <cam@neo-zeon.de>, Sami Loone <sami@loone.fi>,
Elia Devito <eliadevito@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Jack Yu <jack.yu@realtek.com>, "Arnd Bergmann" <arnd@arndb.de>,
Lars-Peter Clausen <lars@metafoo.de>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
<alsa-devel@alsa-project.org>, <linux-acpi@vger.kernel.org>,
<patches@opensource.cirrus.com>,
<platform-driver-x86@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 01/11] ASoC: cs35l41: Set the max SPI speed for the whole device
Date: Tue, 23 Nov 2021 18:02:53 +0000 [thread overview]
Message-ID: <20211123180253.GF18506@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <20211123163149.1530535-2-tanureal@opensource.cirrus.com>
On Tue, Nov 23, 2021 at 04:31:39PM +0000, Lucas Tanure wrote:
> Higher speeds are only supported when PLL is enabled, but
> the current driver doesn't enable PLL outside of stream
> use cases, so better to set the lowest SPI speed accepted
> by the entire device.
>
> Move the current frequency set to the spi sub-driver so
> the whole device can benefit from that speed.
>
> spi-max-frequency property could be used, but ACPI systems don't
> support it, so by setting it in the spi sub-driver probe
> both Device Trees and ACPI systems are supported.
>
> Signed-off-by: Lucas Tanure <tanureal@opensource.cirrus.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
next prev parent reply other threads:[~2021-11-23 18:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 16:31 [PATCH v3 00/11] Add support for Legion 7 16ACHg6 laptop Lucas Tanure
2021-11-23 16:31 ` [PATCH 01/11] ASoC: cs35l41: Set the max SPI speed for the whole device Lucas Tanure
2021-11-23 18:02 ` Charles Keepax [this message]
2021-11-23 16:31 ` [PATCH 02/11] ASoC: cs35l41: Convert tables to shared source code Lucas Tanure
2021-11-23 17:53 ` Mark Brown
2021-11-23 18:05 ` Charles Keepax
2021-11-23 16:31 ` [PATCH 03/11] ASoC: cs35l41: Move regmap config struct to shared code Lucas Tanure
2021-11-23 17:20 ` Mark Brown
2021-11-23 16:31 ` [PATCH 04/11] ASoC: cs35l41: Create function for init array of Supplies Lucas Tanure
2021-11-23 17:58 ` Mark Brown
2021-11-24 13:31 ` Mark Brown
2021-11-23 16:31 ` [PATCH 05/11] ASoC: cs35l41: Move cs35l41_otp_unpack to shared code Lucas Tanure
2021-11-23 16:31 ` [PATCH 06/11] ASoC: cs35l41: Move power initializations to reg_sequence Lucas Tanure
2021-11-23 16:31 ` [PATCH 07/11] ASoC: cs35l41: Create shared function for errata patches Lucas Tanure
2021-11-23 16:31 ` [PATCH 08/11] ASoC: cs35l41: Create shared function for setting channels Lucas Tanure
2021-11-23 16:31 ` [PATCH 09/11] ASoC: cs35l41: Create shared function for boost configuration Lucas Tanure
2021-11-23 16:31 ` [PATCH 10/11] hda: cs35l41: Add support for CS35L41 in HDA systems Lucas Tanure
2021-11-23 16:52 ` Takashi Iwai
2021-11-23 16:59 ` Pierre-Louis Bossart
2021-11-23 17:06 ` tanureal
2021-11-23 17:16 ` Pierre-Louis Bossart
2021-11-23 17:15 ` Mark Brown
2021-11-23 16:31 ` [PATCH 11/11] ACPI / scan: Create platform device for CLSA0100 ACPI nodes Lucas Tanure
2021-11-23 17:05 ` Hans de Goede
2021-11-23 17:11 ` Lucas tanure
2021-11-23 18:35 ` Hans de Goede
2021-11-23 23:01 ` Andy Shevchenko
2021-11-24 17:36 ` (subset) [PATCH v3 00/11] Add support for Legion 7 16ACHg6 laptop Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211123180253.GF18506@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=cam@neo-zeon.de \
--cc=chris.chiu@canonical.com \
--cc=david.rhodes@cirrus.com \
--cc=eliadevito@gmail.com \
--cc=hdegoede@redhat.com \
--cc=hui.wang@canonical.com \
--cc=jack.yu@realtek.com \
--cc=jeremy.szu@canonical.com \
--cc=kailang@realtek.com \
--cc=lars@metafoo.de \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=sami@loone.fi \
--cc=shumingf@realtek.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tanureal@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=vitalyr@opensource.cirrus.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®