mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Kaiser <martin@kaiser.cx>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	Michael Straube <straube.linux@gmail.com>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH v2 3/4] staging: r8188eu: remove _ps_close_RF
Date: Fri, 26 Nov 2021 14:03:59 +0100	[thread overview]
Message-ID: <20211126130400.26151-4-martin@kaiser.cx> (raw)
In-Reply-To: <20211126130400.26151-1-martin@kaiser.cx>

The _ps_close_RF is empty. Remove it.

Reviewed-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v2:
 - add Reviewed-by

 drivers/staging/r8188eu/hal/usb_halinit.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
index 995ea4a55435..0b1aaa162c21 100644
--- a/drivers/staging/r8188eu/hal/usb_halinit.c
+++ b/drivers/staging/r8188eu/hal/usb_halinit.c
@@ -850,12 +850,6 @@ u32 rtl8188eu_hal_init(struct adapter *Adapter)
 	return status;
 }
 
-static void _ps_close_RF(struct adapter *adapt)
-{
-	/* here call with bRegSSPwrLvl 1, bRegSSPwrLvl 2 needs to be verified */
-	/* phy_SsPwrSwitch92CU(adapt, rf_off, 1); */
-}
-
 static void CardDisableRTL8188EU(struct adapter *Adapter)
 {
 	u8 val8;
@@ -921,9 +915,7 @@ u32 rtl8188eu_hal_deinit(struct adapter *Adapter)
 	rtw_write32(Adapter, REG_HIMRE_88E, IMR_DISABLED_88E);
 
 	DBG_88E("bkeepfwalive(%x)\n", Adapter->pwrctrlpriv.bkeepfwalive);
-	if (Adapter->pwrctrlpriv.bkeepfwalive) {
-		_ps_close_RF(Adapter);
-	} else {
+	if (!Adapter->pwrctrlpriv.bkeepfwalive) {
 		if (Adapter->hw_init_completed) {
 			CardDisableRTL8188EU(Adapter);
 		}
-- 
2.20.1


  parent reply	other threads:[~2021-11-26 13:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-25 16:47 [PATCH 0/4] staging: r8188eu: some trivial removals Martin Kaiser
2021-11-25 16:47 ` [PATCH 1/4] staging: r8188eu: remove pm_netdev_open Martin Kaiser
2021-11-25 17:43   ` Michael Straube
2021-11-25 16:47 ` [PATCH 2/4] staging: r8188eu: remove _ps_open_RF Martin Kaiser
2021-11-25 17:45   ` Michael Straube
2021-11-25 16:47 ` [PATCH 3/4] staging: r8188eu: remove _ps_close_RF Martin Kaiser
2021-11-25 17:46   ` Michael Straube
2021-11-25 16:47 ` [PATCH 4/4] staging: r8188eu: loadparam needs no net_device Martin Kaiser
2021-11-25 17:48   ` Michael Straube
2021-11-26 13:03 ` [PATCH v2 0/4] staging: r8188eu: some trivial removals Martin Kaiser
2021-11-26 13:03   ` [PATCH v2 1/4] staging: r8188eu: remove pm_netdev_open Martin Kaiser
2021-11-26 13:03   ` [PATCH v2 2/4] staging: r8188eu: remove _ps_open_RF Martin Kaiser
2021-11-27  7:55     ` Michael Straube
2021-11-26 13:03   ` Martin Kaiser [this message]
2021-11-26 13:04   ` [PATCH v2 4/4] staging: r8188eu: loadparam needs no net_device Martin Kaiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211126130400.26151-4-martin@kaiser.cx \
    --to=martin@kaiser.cx \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=phil@philpotter.co.uk \
    --cc=straube.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®