From: Michael Straube <straube.linux@gmail.com>
To: Martin Kaiser <martin@kaiser.cx>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] staging: r8188eu: loadparam needs no net_device
Date: Thu, 25 Nov 2021 18:48:59 +0100 [thread overview]
Message-ID: <8a74f32b-381d-919b-816c-4b93706e6da8@gmail.com> (raw)
In-Reply-To: <20211125164745.8188-5-martin@kaiser.cx>
On 11/25/21 17:47, Martin Kaiser wrote:
> Remove the second parameter of the loadparam function. This parameter
> is not used.
>
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
> drivers/staging/r8188eu/os_dep/os_intfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
> index 397981bc9a62..02700834c587 100644
> --- a/drivers/staging/r8188eu/os_dep/os_intfs.c
> +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
> @@ -153,7 +153,7 @@ MODULE_PARM_DESC(rtw_notch_filter, "0:Disable, 1:Enable, 2:Enable only for P2P")
> module_param_named(debug, rtw_debug, int, 0444);
> MODULE_PARM_DESC(debug, "Set debug level (1-9) (default 1)");
>
> -static uint loadparam(struct adapter *padapter, struct net_device *pnetdev)
> +static uint loadparam(struct adapter *padapter)
> {
> struct registry_priv *registry_par = &padapter->registrypriv;
>
> @@ -371,7 +371,7 @@ struct net_device *rtw_init_netdev(struct adapter *old_padapter)
> pnetdev->wireless_handlers = (struct iw_handler_def *)&rtw_handlers_def;
>
> /* step 2. */
> - loadparam(padapter, pnetdev);
> + loadparam(padapter);
>
> return pnetdev;
> }
>
Reviewed-by: Michael Straube <straube.linux@gmail.com>
next prev parent reply other threads:[~2021-11-25 17:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-25 16:47 [PATCH 0/4] staging: r8188eu: some trivial removals Martin Kaiser
2021-11-25 16:47 ` [PATCH 1/4] staging: r8188eu: remove pm_netdev_open Martin Kaiser
2021-11-25 17:43 ` Michael Straube
2021-11-25 16:47 ` [PATCH 2/4] staging: r8188eu: remove _ps_open_RF Martin Kaiser
2021-11-25 17:45 ` Michael Straube
2021-11-25 16:47 ` [PATCH 3/4] staging: r8188eu: remove _ps_close_RF Martin Kaiser
2021-11-25 17:46 ` Michael Straube
2021-11-25 16:47 ` [PATCH 4/4] staging: r8188eu: loadparam needs no net_device Martin Kaiser
2021-11-25 17:48 ` Michael Straube [this message]
2021-11-26 13:03 ` [PATCH v2 0/4] staging: r8188eu: some trivial removals Martin Kaiser
2021-11-26 13:03 ` [PATCH v2 1/4] staging: r8188eu: remove pm_netdev_open Martin Kaiser
2021-11-26 13:03 ` [PATCH v2 2/4] staging: r8188eu: remove _ps_open_RF Martin Kaiser
2021-11-27 7:55 ` Michael Straube
2021-11-26 13:03 ` [PATCH v2 3/4] staging: r8188eu: remove _ps_close_RF Martin Kaiser
2021-11-26 13:04 ` [PATCH v2 4/4] staging: r8188eu: loadparam needs no net_device Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a74f32b-381d-919b-816c-4b93706e6da8@gmail.com \
--to=straube.linux@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®