From: Christoph Hellwig <hch@lst.de>
To: luanshi <zhangliguang@linux.alibaba.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: duplicate NQNs check if devices needed
Date: Tue, 30 Nov 2021 07:40:54 +0100 [thread overview]
Message-ID: <20211130064054.GB10268@lst.de> (raw)
In-Reply-To: <5f1be6d6-fa0d-8084-ccf1-7a3af6506046@linux.alibaba.com>
On Tue, Nov 30, 2021 at 01:04:55PM +0800, luanshi wrote:
> Hi Keith,
>
> 在 2021/11/30 0:34, Keith Busch 写道:
>> On Mon, Nov 29, 2021 at 07:18:54PM +0800, Liguang Zhang wrote:
>>> @@ -2587,6 +2587,9 @@ static struct nvme_subsystem *__nvme_find_get_subsystem(const char *subsysnqn)
>>> lockdep_assert_held(&nvme_subsystems_lock);
>>> + if (strncmp(subsysnqn, "nqn.", 4))
>>> + return NULL;
>> This seems like an arbitrary way to decide not to check for duplicates.
>> Shouldn't we just add the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk for the
>> broken controllers?
>
> Yeah, add the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk is a way to resolve the
> problem. I do not
>
> have enough controller in my hand, I don't make sure all the controller are
> covered. And there are some
What does this broken device report in the subnqn field?
next prev parent reply other threads:[~2021-11-30 6:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 11:18 Liguang Zhang
2021-11-29 16:34 ` Keith Busch
2021-11-29 18:48 ` Chaitanya Kulkarni
2021-11-30 5:04 ` luanshi
2021-11-30 6:40 ` Christoph Hellwig [this message]
2021-11-30 6:58 ` luanshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211130064054.GB10268@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®