From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Liguang Zhang <zhangliguang@linux.alibaba.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH] nvme: duplicate NQNs check if devices needed
Date: Mon, 29 Nov 2021 18:48:38 +0000 [thread overview]
Message-ID: <f7dedda8-a739-0af7-95c7-5e4c1f574ff7@nvidia.com> (raw)
In-Reply-To: <20211129163406.GA3582042@dhcp-10-100-145-180.wdc.com>
Liguang,
On 11/29/21 8:34 AM, Keith Busch wrote:
> On Mon, Nov 29, 2021 at 07:18:54PM +0800, Liguang Zhang wrote:
>> @@ -2587,6 +2587,9 @@ static struct nvme_subsystem *__nvme_find_get_subsystem(const char *subsysnqn)
>>
>> lockdep_assert_held(&nvme_subsystems_lock);
>>
>> + if (strncmp(subsysnqn, "nqn.", 4))
>> + return NULL;
>
> This seems like an arbitrary way to decide not to check for duplicates.
> Shouldn't we just add the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk for the
> broken controllers?
>
Please add t he quirk for a specific controller(s) as mentioned
by Keith.
-ck
next prev parent reply other threads:[~2021-11-29 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-29 11:18 Liguang Zhang
2021-11-29 16:34 ` Keith Busch
2021-11-29 18:48 ` Chaitanya Kulkarni [this message]
2021-11-30 5:04 ` luanshi
2021-11-30 6:40 ` Christoph Hellwig
2021-11-30 6:58 ` luanshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7dedda8-a739-0af7-95c7-5e4c1f574ff7@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®