From: Philippe Schenker <philippe.schenker@toradex.com>
To: netdev@vger.kernel.org, Joakim Zhang <qiangqing.zhang@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Fugang Duan <fugang.duan@nxp.com>,
"David S . Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
Andrew Lunn <andrew@lunn.ch>, Jakub Kicinski <kuba@kernel.org>
Cc: Philippe Schenker <philippe.schenker@toradex.com>,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 2/2] net: fec: reset phy in resume if it was powered down
Date: Mon, 6 Dec 2021 11:13:26 +0100 [thread overview]
Message-ID: <20211206101326.1022527-3-philippe.schenker@toradex.com> (raw)
In-Reply-To: <20211206101326.1022527-1-philippe.schenker@toradex.com>
If a board solely rely on a GPIO to reset the PHY after power-up, the
PHY won't work after a power-down where the power was cut.
Reset the PHY after power-enable in fec_resume.
Signed-off-by: Philippe Schenker <philippe.schenker@toradex.com>
---
drivers/net/ethernet/freescale/fec_main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 92840f18c48f..41c3825cd768 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -4118,6 +4118,10 @@ static int __maybe_unused fec_resume(struct device *dev)
ret = regulator_enable(fep->reg_phy);
if (ret)
return ret;
+
+ ret = fec_reset_phy(ndev);
+ if (ret)
+ return ret;
}
rtnl_lock();
--
2.34.0
next prev parent reply other threads:[~2021-12-06 10:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 10:13 [RFC PATCH 0/2] Reset PHY in fec_resume if it got " Philippe Schenker
2021-12-06 10:13 ` [RFC PATCH 1/2] net: fec: make fec_reset_phy not only usable once Philippe Schenker
2021-12-06 13:13 ` Andrew Lunn
2021-12-06 10:13 ` Philippe Schenker [this message]
2021-12-07 1:58 ` [RFC PATCH 0/2] Reset PHY in fec_resume if it got powered down Joakim Zhang
2021-12-10 13:51 ` Philippe Schenker
2021-12-11 13:01 ` [PATCH net-next] net: phy: perform a PHY reset on resume Francesco Dolcini
2021-12-11 14:15 ` Russell King (Oracle)
2021-12-11 14:57 ` Francesco Dolcini
2021-12-14 11:58 ` Francesco Dolcini
2021-12-13 4:40 ` Joakim Zhang
2021-12-13 10:57 ` Philippe Schenker
2021-12-13 4:39 ` [RFC PATCH 0/2] Reset PHY in fec_resume if it got powered down Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206101326.1022527-3-philippe.schenker@toradex.com \
--to=philippe.schenker@toradex.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=fugang.duan@nxp.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®