From: Francesco Dolcini <francesco.dolcini@toradex.com>
To: philippe.schenker@toradex.com, andrew@lunn.ch, qiangqing.zhang@nxp.com
Cc: davem@davemloft.net, festevam@gmail.com, kuba@kernel.org,
linux-kernel@vger.kernel.org, linux@armlinux.org.uk,
netdev@vger.kernel.org,
Francesco Dolcini <francesco.dolcini@toradex.com>
Subject: [PATCH net-next] net: phy: perform a PHY reset on resume
Date: Sat, 11 Dec 2021 14:01:46 +0100 [thread overview]
Message-ID: <20211211130146.357794-1-francesco.dolcini@toradex.com> (raw)
In-Reply-To: <7a4830b495e5e819a2b2b39dd01785aa3eba4ce7.camel@toradex.com>
Perform a PHY reset in phy_init_hw() to ensure that the PHY is working
after resume. This is required if the PHY was powered down in suspend
like it is done by the freescale FEC driver in fec_suspend().
Link: https://lore.kernel.org/netdev/20211206101326.1022527-1-philippe.schenker@toradex.com/
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
Philippe: what about something like that? Only compile tested, but I see no reason for this not solving the issue.
Any delay required on the reset can be specified using reset-assert-us/reset-deassert-us.
---
drivers/net/phy/phy_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c
index 74d8e1dc125f..7eab0c054adf 100644
--- a/drivers/net/phy/phy_device.c
+++ b/drivers/net/phy/phy_device.c
@@ -1158,7 +1158,8 @@ int phy_init_hw(struct phy_device *phydev)
{
int ret = 0;
- /* Deassert the reset signal */
+ /* phy reset required if the phy was powered down during suspend */
+ phy_device_reset(phydev, 1);
phy_device_reset(phydev, 0);
if (!phydev->drv)
--
2.25.1
next prev parent reply other threads:[~2021-12-11 13:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 10:13 [RFC PATCH 0/2] Reset PHY in fec_resume if it got powered down Philippe Schenker
2021-12-06 10:13 ` [RFC PATCH 1/2] net: fec: make fec_reset_phy not only usable once Philippe Schenker
2021-12-06 13:13 ` Andrew Lunn
2021-12-06 10:13 ` [RFC PATCH 2/2] net: fec: reset phy in resume if it was powered down Philippe Schenker
2021-12-07 1:58 ` [RFC PATCH 0/2] Reset PHY in fec_resume if it got " Joakim Zhang
2021-12-10 13:51 ` Philippe Schenker
2021-12-11 13:01 ` Francesco Dolcini [this message]
2021-12-11 14:15 ` [PATCH net-next] net: phy: perform a PHY reset on resume Russell King (Oracle)
2021-12-11 14:57 ` Francesco Dolcini
2021-12-14 11:58 ` Francesco Dolcini
2021-12-13 4:40 ` Joakim Zhang
2021-12-13 10:57 ` Philippe Schenker
2021-12-13 4:39 ` [RFC PATCH 0/2] Reset PHY in fec_resume if it got powered down Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211211130146.357794-1-francesco.dolcini@toradex.com \
--to=francesco.dolcini@toradex.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=philippe.schenker@toradex.com \
--cc=qiangqing.zhang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®