From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel@vger.kernel.org, Borislav Petkov <bp@alien8.de>,
Jiri Slaby <jslaby@suse.cz>, Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: ardb@kernel.org, broonie@kernel.org, catalin.marinas@arm.com,
dave.hansen@linux.intel.com,
linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com,
maz@kernel.org, mingo@redhat.com, tabba@google.com,
tglx@linutronix.de, will@kernel.org
Subject: [RFC PATCH 0/6] linkage: better symbol aliasing
Date: Mon, 6 Dec 2021 12:47:09 +0000 [thread overview]
Message-ID: <20211206124715.4101571-1-mark.rutland@arm.com> (raw)
This series aims to make symbol aliasing simpler and more consistent.
The basic idea is to replace SYM_FUNC_START_ALIAS(alias) and
SYM_FUNC_END_ALIAS(alias) with a new SYM_FUNC_ALIAS(alias, name), so
that e.g.
SYM_FUNC_START(func)
SYM_FUNC_START_ALIAS(alias1)
SYM_FUNC_START_ALIAS(alias2)
... asm insns ...
SYM_FUNC_END(func)
SYM_FUNC_END_ALIAS(alias1)
SYM_FUNC_END_ALIAS(alias2)
EXPORT_SYMBOL(alias1)
EXPORT_SYMBOL(alias2)
... can become:
SYM_FUNC_START(name)
... asm insns ...
SYM_FUNC_END(name)
SYM_FUNC_ALIAS(alias1, func)
EXPORT_SYMBOL(alias1)
SYM_FUNC_ALIAS(alias2, func)
EXPORT_SYMBOL(alias2)
This avoids repetition and hopefully make it easier to ensure
consistency (e.g. so each function has a single canonical name and
associated metadata).
I'm sending this as an RFC since I want to check:
a) People are happy with the idea in principle.
b) People are happy with the implementation within <linux/linkage.h>.
... and I haven't yet converted the headers under tools/, which is
largely a copy+paste job.
I've build+boot tested arm64 and x86 defconfig without issues, and I've
pushed the series to my `linkage/alias-rework` branch on git.kernel.org,
atop v5.16-rc3:
git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git linkage/alias-rework
https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=linkage/alias-rework
Thanks,
Mark.
Mark Rutland (6):
linkage: add SYM_{ENTRY,START,END}_AT()
linkage: add SYM_FUNC_{LOCAL_,}ALIAS()
arm64: remove __dma_*_area() aliases
arm64: clean up symbol aliasing
x86: clean up symbol aliasing
linkage: remove START/END ALIAS macros
Documentation/asm-annotations.rst | 11 ++--
arch/arm64/include/asm/linkage.h | 24 ---------
arch/arm64/kvm/hyp/nvhe/cache.S | 5 +-
arch/arm64/lib/clear_page.S | 5 +-
arch/arm64/lib/copy_page.S | 5 +-
arch/arm64/lib/memchr.S | 5 +-
arch/arm64/lib/memcmp.S | 6 +--
arch/arm64/lib/memcpy.S | 21 ++++----
arch/arm64/lib/memset.S | 12 +++--
arch/arm64/lib/strchr.S | 6 ++-
arch/arm64/lib/strcmp.S | 6 +--
arch/arm64/lib/strlen.S | 6 +--
arch/arm64/lib/strncmp.S | 8 +--
arch/arm64/lib/strnlen.S | 6 ++-
arch/arm64/lib/strrchr.S | 5 +-
arch/arm64/mm/cache.S | 59 +++++++++-----------
arch/x86/boot/compressed/head_32.S | 3 +-
arch/x86/boot/compressed/head_64.S | 3 +-
arch/x86/lib/memcpy_64.S | 10 ++--
arch/x86/lib/memmove_64.S | 4 +-
arch/x86/lib/memset_64.S | 6 +--
include/linux/linkage.h | 86 ++++++++++++++++++------------
22 files changed, 146 insertions(+), 156 deletions(-)
--
2.30.2
next reply other threads:[~2021-12-06 12:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 12:47 Mark Rutland [this message]
2021-12-06 12:47 ` [RFC PATCH 1/6] linkage: add SYM_{ENTRY,START,END}_AT() Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 2/6] linkage: add SYM_FUNC_{LOCAL_,}ALIAS() Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 3/6] arm64: remove __dma_*_area() aliases Mark Rutland
2021-12-10 15:02 ` Catalin Marinas
2021-12-06 12:47 ` [RFC PATCH 4/6] arm64: clean up symbol aliasing Mark Rutland
2021-12-10 15:02 ` Catalin Marinas
2021-12-06 12:47 ` [RFC PATCH 5/6] x86: " Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 6/6] linkage: remove START/END ALIAS macros Mark Rutland
2021-12-06 14:06 ` [RFC PATCH 0/6] linkage: better symbol aliasing Ard Biesheuvel
2021-12-06 15:10 ` Mark Brown
2021-12-07 5:23 ` Josh Poimboeuf
2021-12-07 13:33 ` Mark Rutland
2021-12-10 15:04 ` Catalin Marinas
2021-12-15 9:24 ` Mark Rutland
2021-12-15 11:28 ` (subset) " Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206124715.4101571-1-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tabba@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®