From: Mark Rutland <mark.rutland@arm.com>
To: linux-kernel@vger.kernel.org
Cc: ardb@kernel.org, bp@alien8.de, broonie@kernel.org,
catalin.marinas@arm.com, dave.hansen@linux.intel.com,
jpoimboe@redhat.com, jslaby@suse.cz,
linux-arm-kernel@lists.infradead.org, mark.rutland@arm.com,
maz@kernel.org, mingo@redhat.com, peterz@infradead.org,
tabba@google.com, tglx@linutronix.de, will@kernel.org
Subject: [RFC PATCH 3/6] arm64: remove __dma_*_area() aliases
Date: Mon, 6 Dec 2021 12:47:12 +0000 [thread overview]
Message-ID: <20211206124715.4101571-4-mark.rutland@arm.com> (raw)
In-Reply-To: <20211206124715.4101571-1-mark.rutland@arm.com>
The __dma_inv_area() and __dma_clean_area() aliases make cache.S harder
to navigate, but don't gain us anything in practice.
For clarity, let's remove them along with their redundant comments. The
only users are __dma_map_area() and __dma_unmap_area(), which need to be
position independent, and can call __pi_dcache_inval_poc() and
__pi_dcache_clean_poc() directly.
There should be no functional change as a result of this patch.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Fuad Tabba <tabba@google.com>
Cc: Marc Zyngier <maz@kernel.org>
Cc: Will Deacon <will@kernel.org>
---
arch/arm64/mm/cache.S | 24 +++---------------------
1 file changed, 3 insertions(+), 21 deletions(-)
diff --git a/arch/arm64/mm/cache.S b/arch/arm64/mm/cache.S
index 5051b3c1a4f1..7d0563db4201 100644
--- a/arch/arm64/mm/cache.S
+++ b/arch/arm64/mm/cache.S
@@ -140,15 +140,7 @@ SYM_FUNC_END(dcache_clean_pou)
* - start - kernel start address of region
* - end - kernel end address of region
*/
-SYM_FUNC_START_LOCAL(__dma_inv_area)
SYM_FUNC_START_PI(dcache_inval_poc)
- /* FALLTHROUGH */
-
-/*
- * __dma_inv_area(start, end)
- * - start - virtual start address of region
- * - end - virtual end address of region
- */
dcache_line_size x2, x3
sub x3, x2, #1
tst x1, x3 // end cache line aligned?
@@ -167,7 +159,6 @@ SYM_FUNC_START_PI(dcache_inval_poc)
dsb sy
ret
SYM_FUNC_END_PI(dcache_inval_poc)
-SYM_FUNC_END(__dma_inv_area)
/*
* dcache_clean_poc(start, end)
@@ -178,19 +169,10 @@ SYM_FUNC_END(__dma_inv_area)
* - start - virtual start address of region
* - end - virtual end address of region
*/
-SYM_FUNC_START_LOCAL(__dma_clean_area)
SYM_FUNC_START_PI(dcache_clean_poc)
- /* FALLTHROUGH */
-
-/*
- * __dma_clean_area(start, end)
- * - start - virtual start address of region
- * - end - virtual end address of region
- */
dcache_by_line_op cvac, sy, x0, x1, x2, x3
ret
SYM_FUNC_END_PI(dcache_clean_poc)
-SYM_FUNC_END(__dma_clean_area)
/*
* dcache_clean_pop(start, end)
@@ -232,8 +214,8 @@ SYM_FUNC_END_PI(__dma_flush_area)
SYM_FUNC_START_PI(__dma_map_area)
add x1, x0, x1
cmp w2, #DMA_FROM_DEVICE
- b.eq __dma_inv_area
- b __dma_clean_area
+ b.eq __pi_dcache_inval_poc
+ b __pi_dcache_clean_poc
SYM_FUNC_END_PI(__dma_map_area)
/*
@@ -245,6 +227,6 @@ SYM_FUNC_END_PI(__dma_map_area)
SYM_FUNC_START_PI(__dma_unmap_area)
add x1, x0, x1
cmp w2, #DMA_TO_DEVICE
- b.ne __dma_inv_area
+ b.ne __pi_dcache_inval_poc
ret
SYM_FUNC_END_PI(__dma_unmap_area)
--
2.30.2
next prev parent reply other threads:[~2021-12-06 12:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-06 12:47 [RFC PATCH 0/6] linkage: better symbol aliasing Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 1/6] linkage: add SYM_{ENTRY,START,END}_AT() Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 2/6] linkage: add SYM_FUNC_{LOCAL_,}ALIAS() Mark Rutland
2021-12-06 12:47 ` Mark Rutland [this message]
2021-12-10 15:02 ` [RFC PATCH 3/6] arm64: remove __dma_*_area() aliases Catalin Marinas
2021-12-06 12:47 ` [RFC PATCH 4/6] arm64: clean up symbol aliasing Mark Rutland
2021-12-10 15:02 ` Catalin Marinas
2021-12-06 12:47 ` [RFC PATCH 5/6] x86: " Mark Rutland
2021-12-06 12:47 ` [RFC PATCH 6/6] linkage: remove START/END ALIAS macros Mark Rutland
2021-12-06 14:06 ` [RFC PATCH 0/6] linkage: better symbol aliasing Ard Biesheuvel
2021-12-06 15:10 ` Mark Brown
2021-12-07 5:23 ` Josh Poimboeuf
2021-12-07 13:33 ` Mark Rutland
2021-12-10 15:04 ` Catalin Marinas
2021-12-15 9:24 ` Mark Rutland
2021-12-15 11:28 ` (subset) " Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211206124715.4101571-4-mark.rutland@arm.com \
--to=mark.rutland@arm.com \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tabba@google.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®