* [PATCH] binder: fix pointer cast warning
@ 2021-12-07 12:24 Arnd Bergmann
2021-12-07 16:51 ` Todd Kjos
2021-12-08 10:09 ` Christian Brauner
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2021-12-07 12:24 UTC (permalink / raw)
To: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Hridya Valsaraju, Suren Baghdasaryan
Cc: Arnd Bergmann, Li Li, Marco Ballesio, Hang Lu, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
binder_uintptr_t is not the same as uintptr_t, so converting it into a
pointer requires a second cast:
drivers/android/binder.c: In function 'binder_translate_fd_array':
drivers/android/binder.c:2511:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
2511 | sender_ufda_base = (void __user *)sender_uparent->buffer + fda->parent_offset;
| ^
Fixes: 656e01f3ab54 ("binder: read pre-translated fds from sender buffer")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/android/binder.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 5497797ab258..182bb4221b06 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2508,7 +2508,8 @@ static int binder_translate_fd_array(struct list_head *pf_head,
*/
fda_offset = (parent->buffer - (uintptr_t)t->buffer->user_data) +
fda->parent_offset;
- sender_ufda_base = (void __user *)sender_uparent->buffer + fda->parent_offset;
+ sender_ufda_base = (void __user *)(uintptr_t)sender_uparent->buffer +
+ fda->parent_offset;
if (!IS_ALIGNED((unsigned long)fda_offset, sizeof(u32)) ||
!IS_ALIGNED((unsigned long)sender_ufda_base, sizeof(u32))) {
--
2.29.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] binder: fix pointer cast warning
2021-12-07 12:24 [PATCH] binder: fix pointer cast warning Arnd Bergmann
@ 2021-12-07 16:51 ` Todd Kjos
2021-12-08 10:09 ` Christian Brauner
1 sibling, 0 replies; 4+ messages in thread
From: Todd Kjos @ 2021-12-07 16:51 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Hridya Valsaraju, Suren Baghdasaryan, Arnd Bergmann, Li Li,
Marco Ballesio, Hang Lu, linux-kernel
On Tue, Dec 7, 2021 at 4:25 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> binder_uintptr_t is not the same as uintptr_t, so converting it into a
> pointer requires a second cast:
>
> drivers/android/binder.c: In function 'binder_translate_fd_array':
> drivers/android/binder.c:2511:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> 2511 | sender_ufda_base = (void __user *)sender_uparent->buffer + fda->parent_offset;
> | ^
>
> Fixes: 656e01f3ab54 ("binder: read pre-translated fds from sender buffer")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Todd Kjos <tkjos@google.com>
> ---
> drivers/android/binder.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 5497797ab258..182bb4221b06 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -2508,7 +2508,8 @@ static int binder_translate_fd_array(struct list_head *pf_head,
> */
> fda_offset = (parent->buffer - (uintptr_t)t->buffer->user_data) +
> fda->parent_offset;
> - sender_ufda_base = (void __user *)sender_uparent->buffer + fda->parent_offset;
> + sender_ufda_base = (void __user *)(uintptr_t)sender_uparent->buffer +
> + fda->parent_offset;
>
> if (!IS_ALIGNED((unsigned long)fda_offset, sizeof(u32)) ||
> !IS_ALIGNED((unsigned long)sender_ufda_base, sizeof(u32))) {
> --
> 2.29.2
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] binder: fix pointer cast warning
2021-12-07 12:24 [PATCH] binder: fix pointer cast warning Arnd Bergmann
2021-12-07 16:51 ` Todd Kjos
@ 2021-12-08 10:09 ` Christian Brauner
2021-12-08 14:59 ` Randy Dunlap
1 sibling, 1 reply; 4+ messages in thread
From: Christian Brauner @ 2021-12-08 10:09 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Hridya Valsaraju, Suren Baghdasaryan, Arnd Bergmann, Li Li,
Marco Ballesio, Hang Lu, linux-kernel
On Tue, Dec 07, 2021 at 01:24:42PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> binder_uintptr_t is not the same as uintptr_t, so converting it into a
> pointer requires a second cast:
>
> drivers/android/binder.c: In function 'binder_translate_fd_array':
> drivers/android/binder.c:2511:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
> 2511 | sender_ufda_base = (void __user *)sender_uparent->buffer + fda->parent_offset;
> | ^
>
> Fixes: 656e01f3ab54 ("binder: read pre-translated fds from sender buffer")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
Looks good.
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] binder: fix pointer cast warning
2021-12-08 10:09 ` Christian Brauner
@ 2021-12-08 14:59 ` Randy Dunlap
0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-12-08 14:59 UTC (permalink / raw)
To: Christian Brauner, Arnd Bergmann
Cc: Greg Kroah-Hartman, Arve Hjønnevåg, Todd Kjos,
Martijn Coenen, Joel Fernandes, Christian Brauner,
Hridya Valsaraju, Suren Baghdasaryan, Arnd Bergmann, Li Li,
Marco Ballesio, Hang Lu, linux-kernel
On 12/8/21 02:09, Christian Brauner wrote:
> On Tue, Dec 07, 2021 at 01:24:42PM +0100, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> binder_uintptr_t is not the same as uintptr_t, so converting it into a
>> pointer requires a second cast:
>>
>> drivers/android/binder.c: In function 'binder_translate_fd_array':
>> drivers/android/binder.c:2511:28: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast]
>> 2511 | sender_ufda_base = (void __user *)sender_uparent->buffer + fda->parent_offset;
>> | ^
>>
>> Fixes: 656e01f3ab54 ("binder: read pre-translated fds from sender buffer")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>
> Looks good.
> Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-12-08 15:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-07 12:24 [PATCH] binder: fix pointer cast warning Arnd Bergmann
2021-12-07 16:51 ` Todd Kjos
2021-12-08 10:09 ` Christian Brauner
2021-12-08 14:59 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®