* [PATCH] x86/events/amd/iommu: remove redundant assignment to variable shift
@ 2021-12-07 18:50 Colin Ian King
2021-12-28 20:49 ` [tip: x86/cleanups] x86/events/amd/iommu: Remove " tip-bot2 for Colin Ian King
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2021-12-07 18:50 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar, Arnaldo Carvalho de Melo,
Mark Rutland, Alexander Shishkin, Jiri Olsa, Namhyung Kim,
Thomas Gleixner, Borislav Petkov, Dave Hansen, x86,
H . Peter Anvin, linux-perf-users
Cc: kernel-janitors, linux-kernel
Variable shift is being initialized with a value that is never read, it
is being re-assigned later inside a loop. The assignment is redundant
and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
arch/x86/events/amd/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c
index 913745f1419b..b15f7b950d2e 100644
--- a/arch/x86/events/amd/iommu.c
+++ b/arch/x86/events/amd/iommu.c
@@ -161,7 +161,7 @@ static int get_next_avail_iommu_bnk_cntr(struct perf_event *event)
raw_spin_lock_irqsave(&piommu->lock, flags);
- for (bank = 0, shift = 0; bank < max_banks; bank++) {
+ for (bank = 0; bank < max_banks; bank++) {
for (cntr = 0; cntr < max_cntrs; cntr++) {
shift = bank + (bank*3) + cntr;
if (piommu->cntr_assign_mask & BIT_ULL(shift)) {
--
2.33.1
^ permalink raw reply [flat|nested] 2+ messages in thread* [tip: x86/cleanups] x86/events/amd/iommu: Remove redundant assignment to variable shift
2021-12-07 18:50 [PATCH] x86/events/amd/iommu: remove redundant assignment to variable shift Colin Ian King
@ 2021-12-28 20:49 ` tip-bot2 for Colin Ian King
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Colin Ian King @ 2021-12-28 20:49 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Colin Ian King, Borislav Petkov, x86, linux-kernel
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 0be4838f018c10d7f138a213c006d345db35ef5b
Gitweb: https://git.kernel.org/tip/0be4838f018c10d7f138a213c006d345db35ef5b
Author: Colin Ian King <colin.i.king@gmail.com>
AuthorDate: Tue, 07 Dec 2021 18:50:01
Committer: Borislav Petkov <bp@suse.de>
CommitterDate: Tue, 28 Dec 2021 21:30:05 +01:00
x86/events/amd/iommu: Remove redundant assignment to variable shift
Variable shift is being initialized with a value that is never read, it
is being re-assigned later inside a loop. The assignment is redundant
and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Link: https://lore.kernel.org/r/20211207185001.1412413-1-colin.i.king@gmail.com
---
arch/x86/events/amd/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/events/amd/iommu.c b/arch/x86/events/amd/iommu.c
index 913745f..b15f7b9 100644
--- a/arch/x86/events/amd/iommu.c
+++ b/arch/x86/events/amd/iommu.c
@@ -161,7 +161,7 @@ static int get_next_avail_iommu_bnk_cntr(struct perf_event *event)
raw_spin_lock_irqsave(&piommu->lock, flags);
- for (bank = 0, shift = 0; bank < max_banks; bank++) {
+ for (bank = 0; bank < max_banks; bank++) {
for (cntr = 0; cntr < max_cntrs; cntr++) {
shift = bank + (bank*3) + cntr;
if (piommu->cntr_assign_mask & BIT_ULL(shift)) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-28 20:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-07 18:50 [PATCH] x86/events/amd/iommu: remove redundant assignment to variable shift Colin Ian King
2021-12-28 20:49 ` [tip: x86/cleanups] x86/events/amd/iommu: Remove " tip-bot2 for Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®