* [PATCH v4] futex: Clarify comment at futex_wait_multiple_setup()
@ 2021-12-09 17:14 6812skiii
2021-12-09 17:18 ` André Almeida
0 siblings, 1 reply; 2+ messages in thread
From: 6812skiii @ 2021-12-09 17:14 UTC (permalink / raw)
To: tglx, mingo
Cc: peterz, dvhart, dave, andrealmeid, linux-kernel, Jangwoong Kim
From: Jangwoong Kim <6812skiii@gmail.com>
Signed-off-by: Jangwoong Kim <6812skiii@gmail.com>
---
kernel/futex/waitwake.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/kernel/futex/waitwake.c b/kernel/futex/waitwake.c
index 4ce0923f1ce3..c7a14ebfe61d 100644
--- a/kernel/futex/waitwake.c
+++ b/kernel/futex/waitwake.c
@@ -454,9 +454,9 @@ static int futex_wait_multiple_setup(struct futex_vector *vs, int count, int *wo
__set_current_state(TASK_RUNNING);
/*
- * Even if something went wrong, if we find out that a futex
- * was woken, we don't return error and return this index to
- * userspace
+ * Even if something went wrong, if we find out that any futex
+ * was woken, we don't return error and return the index of the
+ * last futex awaken to userspace
*/
*woken = unqueue_multiple(vs, i);
if (*woken >= 0)
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v4] futex: Clarify comment at futex_wait_multiple_setup()
2021-12-09 17:14 [PATCH v4] futex: Clarify comment at futex_wait_multiple_setup() 6812skiii
@ 2021-12-09 17:18 ` André Almeida
0 siblings, 0 replies; 2+ messages in thread
From: André Almeida @ 2021-12-09 17:18 UTC (permalink / raw)
To: 6812skiii, tglx, mingo; +Cc: peterz, dvhart, dave, linux-kernel
Às 14:14 de 09/12/21, 6812skiii@gmail.com escreveu:
> From: Jangwoong Kim <6812skiii@gmail.com>
>
Almost there, this time you forgot to write something here in the commit
description :)
> Signed-off-by: Jangwoong Kim <6812skiii@gmail.com>
> ---
> kernel/futex/waitwake.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/futex/waitwake.c b/kernel/futex/waitwake.c
> index 4ce0923f1ce3..c7a14ebfe61d 100644
> --- a/kernel/futex/waitwake.c
> +++ b/kernel/futex/waitwake.c
> @@ -454,9 +454,9 @@ static int futex_wait_multiple_setup(struct futex_vector *vs, int count, int *wo
> __set_current_state(TASK_RUNNING);
>
> /*
> - * Even if something went wrong, if we find out that a futex
> - * was woken, we don't return error and return this index to
> - * userspace
> + * Even if something went wrong, if we find out that any futex
> + * was woken, we don't return error and return the index of the
> + * last futex awaken to userspace
> */
> *woken = unqueue_multiple(vs, i);
> if (*woken >= 0)
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-09 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-09 17:14 [PATCH v4] futex: Clarify comment at futex_wait_multiple_setup() 6812skiii
2021-12-09 17:18 ` André Almeida
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®