* [PATCH] lib/genalloc: Fix NULL vs IS_ERR() checking
@ 2021-12-11 14:49 Miaoqian Lin
2021-12-12 11:38 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2021-12-11 14:49 UTC (permalink / raw)
Cc: linmq006, Hans de Goede, David Airlie, Daniel Vetter, dri-devel,
linux-kernel
The devm_gen_pool_create() function does not return NULL. It
returns error pointers.
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c
index f28779715ccd..c9e8b3a63c62 100644
--- a/drivers/gpu/drm/vboxvideo/vbox_main.c
+++ b/drivers/gpu/drm/vboxvideo/vbox_main.c
@@ -127,8 +127,8 @@ int vbox_hw_init(struct vbox_private *vbox)
/* Create guest-heap mem-pool use 2^4 = 16 byte chunks */
vbox->guest_pool = devm_gen_pool_create(vbox->ddev.dev, 4, -1,
"vboxvideo-accel");
- if (!vbox->guest_pool)
- return -ENOMEM;
+ if (IS_ERR(vbox->guest_pool))
+ return PTR_ERR(vbox->guest_pool);
ret = gen_pool_add_virt(vbox->guest_pool,
(unsigned long)vbox->guest_heap,
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] lib/genalloc: Fix NULL vs IS_ERR() checking
2021-12-11 14:49 [PATCH] lib/genalloc: Fix NULL vs IS_ERR() checking Miaoqian Lin
@ 2021-12-12 11:38 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-12-12 11:38 UTC (permalink / raw)
To: Miaoqian Lin; +Cc: David Airlie, Daniel Vetter, dri-devel, linux-kernel
Hi,
On 12/11/21 15:49, Miaoqian Lin wrote:
> The devm_gen_pool_create() function does not return NULL. It
> returns error pointers.
>
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
This is already fixed in linux-next, see:
https://cgit.freedesktop.org/drm-misc/commit/drivers/gpu/drm/vboxvideo/vbox_main.c?id=cebbb5c46d0cb0615fd0c62dea9b44273d0a9780
Regards,
Hans
> ---
> drivers/gpu/drm/vboxvideo/vbox_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/vboxvideo/vbox_main.c b/drivers/gpu/drm/vboxvideo/vbox_main.c
> index f28779715ccd..c9e8b3a63c62 100644
> --- a/drivers/gpu/drm/vboxvideo/vbox_main.c
> +++ b/drivers/gpu/drm/vboxvideo/vbox_main.c
> @@ -127,8 +127,8 @@ int vbox_hw_init(struct vbox_private *vbox)
> /* Create guest-heap mem-pool use 2^4 = 16 byte chunks */
> vbox->guest_pool = devm_gen_pool_create(vbox->ddev.dev, 4, -1,
> "vboxvideo-accel");
> - if (!vbox->guest_pool)
> - return -ENOMEM;
> + if (IS_ERR(vbox->guest_pool))
> + return PTR_ERR(vbox->guest_pool);
>
> ret = gen_pool_add_virt(vbox->guest_pool,
> (unsigned long)vbox->guest_heap,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-12 11:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-11 14:49 [PATCH] lib/genalloc: Fix NULL vs IS_ERR() checking Miaoqian Lin
2021-12-12 11:38 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®