From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
Sander Vanheule <sander@svanheule.net>,
Bert Vermeulen <bert@biot.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Paul Burton <paulburton@kernel.org>,
Daniel Silsby <dansilsby@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH 9/9] mips: fix Kconfig reference to PHYS_ADDR_T_64BIT
Date: Mon, 13 Dec 2021 12:16:42 +0100 [thread overview]
Message-ID: <20211213111642.11317-10-lukas.bulwahn@gmail.com> (raw)
In-Reply-To: <20211213111642.11317-1-lukas.bulwahn@gmail.com>
Commit d4a451d5fc84 ("arch: remove the ARCH_PHYS_ADDR_T_64BIT config
symbol") removes config ARCH_PHYS_ADDR_T_64BIT with all instances of that
config refactored appropriately. Since then, it is recommended to use the
config PHYS_ADDR_T_64BIT instead.
Commit 171543e75272 ("MIPS: Disallow CPU_SUPPORTS_HUGEPAGES for XPA,EVA")
introduces the expression "!(32BIT && (ARCH_PHYS_ADDR_T_64BIT || EVA))"
for config CPU_SUPPORTS_HUGEPAGES, which unintentionally refers to the
non-existing symbol ARCH_PHYS_ADDR_T_64BIT instead of the intended
PHYS_ADDR_T_64BIT.
Fix this Kconfig reference to the intended PHYS_ADDR_T_64BIT.
This issue was identified with the script ./scripts/checkkconfigsymbols.py.
I then reported it on the mailing list and Paul confirmed the mistake in
the linked email thread.
Link: https://lore.kernel.org/lkml/H8IU3R.H5QVNRA077PT@crapouillou.net/
Suggested-by: Paul Cercueil <paul@crapouillou.net>
Fixes: 171543e75272 ("MIPS: Disallow CPU_SUPPORTS_HUGEPAGES for XPA,EVA")
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/mips/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index dafc1d62c224..affa31d055d0 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2065,7 +2065,7 @@ config CPU_SUPPORTS_ADDRWINCFG
bool
config CPU_SUPPORTS_HUGEPAGES
bool
- depends on !(32BIT && (ARCH_PHYS_ADDR_T_64BIT || EVA))
+ depends on !(32BIT && (PHYS_ADDR_T_64BIT || EVA))
config MIPS_PGD_C0_CONTEXT
bool
depends on 64BIT
--
2.26.2
next prev parent reply other threads:[~2021-12-13 11:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 11:16 [PATCH 0/9] Kconfig symbol clean-up on ./arch/mips/ Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 1/9] mips: drop selecting the non-existing config SYS_HAS_EARLY_PRINTK_8250 Lukas Bulwahn
2021-12-13 18:52 ` Sander Vanheule
2021-12-14 12:25 ` Lukas Bulwahn
2021-12-15 20:17 ` Sander Vanheule
2021-12-13 11:16 ` [PATCH 2/9] mips: add SYS_HAS_CPU_MIPS64_R5 config for MIPS Release 5 support Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 3/9] mips: drop selecting non-existing config NR_CPUS_DEFAULT_2 Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 4/9] mips: dec: provide the correctly capitalized config CPU_R4X00 in init error message Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 5/9] mips: kgdb: adjust the comment to the actual ifdef condition Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 6/9] mips: remove obsolete selection of CPU_HAS_LOAD_STORE_LR Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 7/9] mips: alchemy: remove historic comment on gpio build constraints Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 8/9] mips: txx9: remove left-over for removed TXX9_ACLC configs Lukas Bulwahn
2021-12-13 11:16 ` Lukas Bulwahn [this message]
2021-12-16 15:03 ` [PATCH 0/9] Kconfig symbol clean-up on ./arch/mips/ Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211213111642.11317-10-lukas.bulwahn@gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bert@biot.com \
--cc=dansilsby@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=sander@svanheule.net \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®