From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Maciej W . Rozycki" <macro@orcam.me.uk>,
Sander Vanheule <sander@svanheule.net>,
Bert Vermeulen <bert@biot.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Serge Semin <Sergey.Semin@baikalelectronics.ru>,
Paul Burton <paulburton@kernel.org>,
Daniel Silsby <dansilsby@gmail.com>,
Paul Cercueil <paul@crapouillou.net>,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH 5/9] mips: kgdb: adjust the comment to the actual ifdef condition
Date: Mon, 13 Dec 2021 12:16:38 +0100 [thread overview]
Message-ID: <20211213111642.11317-6-lukas.bulwahn@gmail.com> (raw)
In-Reply-To: <20211213111642.11317-1-lukas.bulwahn@gmail.com>
The comment refers to CONFIG_CPU_32BIT, but the ifdef uses CONFIG_32BIT.
As this ifdef and comment was introduced with initial mips-kgdb commit
8854700115ec ("[MIPS] kgdb: add arch support for the kernel's kgdb core"),
it is probably just a minor issue that was overlooked during the patch
creation and refactoring before submission.
This inconsistency was identified with ./scripts/checkkconfigsymbols.py.
This script has been quite useful to identify a number of bugs with
Kconfig symbols and deserves to be executed and checked regularly.
So, adjust the comment to the actual ifdef condition to reduce the
reports made the script and simplify to use this script, as new issues
are easier to spot when the list of reports is shorter.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
arch/mips/include/asm/kgdb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/include/asm/kgdb.h b/arch/mips/include/asm/kgdb.h
index 4f2302267deb..b4e210d633c2 100644
--- a/arch/mips/include/asm/kgdb.h
+++ b/arch/mips/include/asm/kgdb.h
@@ -18,7 +18,7 @@
#ifdef CONFIG_32BIT
#define KGDB_GDB_REG_SIZE 32
#define GDB_SIZEOF_REG sizeof(u32)
-#else /* CONFIG_CPU_32BIT */
+#else /* CONFIG_32BIT */
#define KGDB_GDB_REG_SIZE 64
#define GDB_SIZEOF_REG sizeof(u64)
#endif
--
2.26.2
next prev parent reply other threads:[~2021-12-13 11:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 11:16 [PATCH 0/9] Kconfig symbol clean-up on ./arch/mips/ Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 1/9] mips: drop selecting the non-existing config SYS_HAS_EARLY_PRINTK_8250 Lukas Bulwahn
2021-12-13 18:52 ` Sander Vanheule
2021-12-14 12:25 ` Lukas Bulwahn
2021-12-15 20:17 ` Sander Vanheule
2021-12-13 11:16 ` [PATCH 2/9] mips: add SYS_HAS_CPU_MIPS64_R5 config for MIPS Release 5 support Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 3/9] mips: drop selecting non-existing config NR_CPUS_DEFAULT_2 Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 4/9] mips: dec: provide the correctly capitalized config CPU_R4X00 in init error message Lukas Bulwahn
2021-12-13 11:16 ` Lukas Bulwahn [this message]
2021-12-13 11:16 ` [PATCH 6/9] mips: remove obsolete selection of CPU_HAS_LOAD_STORE_LR Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 7/9] mips: alchemy: remove historic comment on gpio build constraints Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 8/9] mips: txx9: remove left-over for removed TXX9_ACLC configs Lukas Bulwahn
2021-12-13 11:16 ` [PATCH 9/9] mips: fix Kconfig reference to PHYS_ADDR_T_64BIT Lukas Bulwahn
2021-12-16 15:03 ` [PATCH 0/9] Kconfig symbol clean-up on ./arch/mips/ Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211213111642.11317-6-lukas.bulwahn@gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=Sergey.Semin@baikalelectronics.ru \
--cc=bert@biot.com \
--cc=dansilsby@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=macro@orcam.me.uk \
--cc=paul@crapouillou.net \
--cc=paulburton@kernel.org \
--cc=sander@svanheule.net \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®